OK, can you generate a pull request for this change?

Thanks,
-Alex

On 5/14/15, 4:01 AM, "kevin.godell" <kevin.god...@gmail.com> wrote:

>Alex Harui wrote
>> Hi Kevin,
>> 
>> Yes, shell scripts are a whole different language.  I’m no expert
>>either.
>> 
>> I think there is a fourth scenario, where FALCON_HOME is set to a folder
>> in a flex-falcon repo, so I’m not sure you can use FALCON_HOME instead
>>of
>> SCRIPT_HOME.
>> 
>> To me, the issue appears to be this portion of the script:
>> 
>> if [ "x${FALCON_HOME}" = "x" ]
>> then
>>     SCRIPT_HOME=`dirname $0`
>>     FALCON_HOME=${SCRIPT_HOME}/../..
>> fi
>> 
>> I think this might need to have SCRIPT_HOME taken out of the if/then and
>> run earlier.  Because if FALCON_HOME is set, then SCRIPT_HOME never gets
>> set
>
>Yes, that makes sense now. I tried to run the script with the 3 scenarios
>of
>unset, trailing slash, and no slash with the code changed to:
>SCRIPT_HOME=`dirname $0`
>if [ "x${FALCON_HOME}" = "x" ]
>then
>    FALCON_HOME=${SCRIPT_HOME}/../..
>fi
>
>and 
>
>-jar "$SCRIPT_HOME/../lib/mxmlc.jar"
>
>It worked.
>
>
>
>--
>View this message in context:
>http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-fle
>x-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-t
>p46455p46505.html
>Sent from the Apache Flex Development mailing list archive at Nabble.com.

Reply via email to