I will do that in about 5 hours when I get home. On Thursday, May 14, 2015, Alex Harui [via Apache Flex Development] < ml-node+s2333347n46550...@n4.nabble.com> wrote:
> OK, can you generate a pull request for this change? > > Thanks, > -Alex > > On 5/14/15, 4:01 AM, "kevin.godell" <[hidden email] > <http:///user/SendEmail.jtp?type=node&node=46550&i=0>> wrote: > > >Alex Harui wrote > >> Hi Kevin, > >> > >> Yes, shell scripts are a whole different language. I’m no expert > >>either. > >> > >> I think there is a fourth scenario, where FALCON_HOME is set to a > folder > >> in a flex-falcon repo, so I’m not sure you can use FALCON_HOME instead > >>of > >> SCRIPT_HOME. > >> > >> To me, the issue appears to be this portion of the script: > >> > >> if [ "x${FALCON_HOME}" = "x" ] > >> then > >> SCRIPT_HOME=`dirname $0` > >> FALCON_HOME=${SCRIPT_HOME}/../.. > >> fi > >> > >> I think this might need to have SCRIPT_HOME taken out of the if/then > and > >> run earlier. Because if FALCON_HOME is set, then SCRIPT_HOME never > gets > >> set > > > >Yes, that makes sense now. I tried to run the script with the 3 scenarios > >of > >unset, trailing slash, and no slash with the code changed to: > >SCRIPT_HOME=`dirname $0` > >if [ "x${FALCON_HOME}" = "x" ] > >then > > FALCON_HOME=${SCRIPT_HOME}/../.. > >fi > > > >and > > > >-jar "$SCRIPT_HOME/../lib/mxmlc.jar" > > > >It worked. > > > > > > > >-- > >View this message in context: > > > http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-fle > >x-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-t > > >p46455p46505.html > >Sent from the Apache Flex Development mailing list archive at Nabble.com. > > > > ------------------------------ > If you reply to this email, your message will be added to the discussion > below: > > http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-flex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-tp46455p46550.html > To start a new topic under Apache Flex Development, email > ml-node+s2333347n1...@n4.nabble.com > <javascript:_e(%7B%7D,'cvml','ml-node%2bs2333347n1...@n4.nabble.com');> > To unsubscribe from Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] > - Revert "Revert "SCRIPT_HOME path had extra slash"", click here > <http://apache-flex-development.2333347.n4.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=46455&code=a2V2aW4uZ29kZWxsQGdtYWlsLmNvbXw0NjQ1NXwyNTAxOTQ4MDU=> > . > NAML > <http://apache-flex-development.2333347.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml> > -- View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-flex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-tp46455p46558.html Sent from the Apache Flex Development mailing list archive at Nabble.com.
