Well, right now, the install() methods have a request() call that is commented out in favor of a get() call. The request call is set up to call the mirrors.cgi, the get() call is set up to grab the nightly. If the install() method could have a parameter passed to it, then we wouldn't have to comment out one path or the other and could just run with an additional parameter to get the nightly, and no parameter hits the mirror.cgi.
I could imagine even more sophisticated code that grabs the latest release URLs from the same place as the installer so we don't have to update the npm scripts as often and maybe lets you choose a version, but that doesn't seem that important to me. -Alex From: "omup...@gmail.com<mailto:omup...@gmail.com>" <omup...@gmail.com<mailto:omup...@gmail.com>> on behalf of OmPrakash Muppirala <bigosma...@gmail.com<mailto:bigosma...@gmail.com>> Date: Tuesday, August 30, 2016 at 1:00 PM To: Alex Harui <aha...@adobe.com<mailto:aha...@adobe.com>> Cc: "dev@flex.apache.org<mailto:dev@flex.apache.org>" <dev@flex.apache.org<mailto:dev@flex.apache.org>>, "harbs.li...@gmail.com<mailto:harbs.li...@gmail.com>" <harbs.li...@gmail.com<mailto:harbs.li...@gmail.com>> Subject: Re: AW: AW: Will we have a new release out the door till 8th of September? Sure we could do that. Can you give more requirements on how the command line switch would need to work? I can try to add this as soon as possible. Thanks, Om On Tue, Aug 30, 2016 at 12:57 PM, Alex Harui <aha...@adobe.com<mailto:aha...@adobe.com>> wrote: Om, Is there a way to pick up command line parameters so we could use a –nightly flag to test against the nightly CI server instead of the mirrors so we could have both code-paths in the repo and wouldn't have to remember to revert some of this code? -Alex From: "omup...@gmail.com<mailto:omup...@gmail.com>" <omup...@gmail.com<mailto:omup...@gmail.com>> on behalf of OmPrakash Muppirala <bigosma...@gmail.com<mailto:bigosma...@gmail.com>> Date: Tuesday, August 30, 2016 at 12:53 PM To: Alex Harui <aha...@adobe.com<mailto:aha...@adobe.com>> Cc: "dev@flex.apache.org<mailto:dev@flex.apache.org>" <dev@flex.apache.org<mailto:dev@flex.apache.org>>, "harbs.li...@gmail.com<mailto:harbs.li...@gmail.com>" <harbs.li...@gmail.com<mailto:harbs.li...@gmail.com>> Subject: Re: AW: AW: Will we have a new release out the door till 8th of September? I just looked over your changes. Looks fine to me. We should remember to revert the hardcoded paths of falcon/flexjs binaries to the mirror urls once we push the release out. Then we can test the npm flexjs distribution one last time and push the module out to npmjs.org<http://npmjs.org> Thanks for pushing this out. It would have taken quite a long time for me to figure out all the changes. Regards, Om On Tue, Aug 30, 2016 at 12:47 PM, Alex Harui <aha...@adobe.com<mailto:aha...@adobe.com>> wrote: OK, I just pushed changes that seem to work with the nightly build. I think we have to update the scripts once more once the final release is out on the mirrors. Then is there a final step where we publish this module to the uber Node registry? I would like to have at least one more PMC member review the release before we cut RCs. I will post more information in the Last Call thread in case folks are filtering for that. -Alex From: "omup...@gmail.com<mailto:omup...@gmail.com>" <omup...@gmail.com<mailto:omup...@gmail.com>> on behalf of OmPrakash Muppirala <bigosma...@gmail.com<mailto:bigosma...@gmail.com>> Date: Monday, August 29, 2016 at 12:37 PM To: Alex Harui <aha...@adobe.com<mailto:aha...@adobe.com>> Cc: "dev@flex.apache.org<mailto:dev@flex.apache.org>" <dev@flex.apache.org<mailto:dev@flex.apache.org>>, "harbs.li...@gmail.com<mailto:harbs.li...@gmail.com>" <harbs.li...@gmail.com<mailto:harbs.li...@gmail.com>> Subject: Re: AW: AW: Will we have a new release out the door till 8th of September? Locally, you can test by simply running: Install: npm install -g Uninstall: npm uninstall flexjs -g If you want to test the one deployed on npm, you need to run: Install: npm install flexjs -g Uninstall: npm uninstall flexjs -g Installing will add the flexjs module to: Windows: C:\Users\<username>\AppData\Roaming\npm\node_modules\flexjs\ Mac: /usr/local/lib/node_modules/flexjs/examples/flexjs/ On Mon, Aug 29, 2016 at 12:31 PM, Alex Harui <aha...@adobe.com<mailto:aha...@adobe.com>> wrote: How do you test changes? Sent from my LG G3, an AT&T 4G LTE smartphone ------ Original message------ From: OmPrakash Muppirala Date: Mon, Aug 29, 2016 11:30 AM To: dev@flex.apache.org<mailto:dev@flex.apache.org>; Cc: Harbs; Subject:Re: AW: AW: Will we have a new release out the door till 8th of September? Still on it. Sorry it turned out to be more work than I thought. Hope to get it done soon. Unless someone wants to jump in and help out. Looks like most of the changes are in this file: https://github.com/apache/flex-utilities/blob/develop/npm-flexjs/dependencies/ApacheFalcon.js Thanks, Om On Mon, Aug 29, 2016 at 7:19 AM, Alex Harui <aha...@adobe.com<mailto:aha...@adobe.com>> wrote: > > > On 8/29/16, 12:31 AM, "Christofer Dutz" > <christofer.d...@c-ware.de<mailto:christofer.d...@c-ware.de>> wrote: > > >So what's the state on this? > > I was hoping to hear from Om that the npm was working again. And I was > hoping to hear from at least one more PMC member that they checked the > release packages and they looked ok. Have you done that? Plus, at least > 3 PMC members were on the road last week. I'd like to get a vote going by > Tuesday or Wednesday. I might be able to work on the npm stuff, but I've > never done it before. > > -Alex > >
