Hi Gordon, I'll move the KeyedDeserializationSchema to the Kafka module.
On Wed, Jan 20, 2016 at 8:24 AM, Tzu-Li (Gordon) Tai <tzuli...@gmail.com> wrote: > Hi Stephan, > > A comment on this. For KeyedDeserializationSchema, I don't think it is > necessary. > As previously explained, the interfaces for the KeyedDeserializationSchema > of Kafka / Kinesis can be quite different, and may also be specific for > future external systems that we might implement connectors to. Wrapper > classes for a common KeyedDeserializationSchema doesn't seem to make sense, > since in the end we will still need to expose system-specific interfaces > for > the user. > > It may be reasonable to keep the most simple DeSerializationSchema > interfaces and wrappers in flink-streaming-java. By a simple > KeyDeserializationSchema, I mean deserialize() methods that only take key > as > byte[] and message as byte[]. If new connectors happen to require more > specific interfaces, then they create them in their own module > (flink-connector-*). > > Cheers, > Gordon > > > > -- > View this message in context: > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/What-is-the-topic-offset-used-for-in-KeyedDeserializationSchema-deserialize-tp9911p9944.html > Sent from the Apache Flink Mailing List archive. mailing list archive at > Nabble.com. >
