I'd like to specify that a PR does not need special attention. Atm you need to specify a person for point 3.
Big +1 for having a command to approve everything until (and also including) a specified state. Cheers, Till On Wed, Feb 13, 2019 at 11:17 AM jincheng sun <sunjincheng...@gmail.com> wrote: > Hi Robert, Thanks for bring up the discussion! I think add the labels is > good idea! > > About the state of labels, I suggest that the state initializes the red X > turns yellow question mark , and turns blue checkmark when approved. > > This way the contributors can know if these tags have been processed. What > to you think? > > Best, > Jincheng > > Robert Metzger <rmetz...@apache.org> 于2019年2月13日周三 下午5:30写道： > > > The first improvement to Flink Bot I would like to introduce is the use > of > > labels. > > > > I’m proposing to apply one of the following labels depending on the > review > > progress: > > > > > > review=needsDescriptionApproval ❌ > > > > review=needsConsensusApproval ❌ > > > > review=needsArchitectureApproval ❌ > > > > review=needsQualityApproval ❌ > > > > review=approved ✅ > > > > > > This is how it looks in my test repository: > > > > [image: Screenshot 2019-02-13 10.24.16.png] > > (screenshot url: > > > https://user-images.githubusercontent.com/89049/52701055-9e022600-2f79-11e9-919e-df4338bc0fa3.png > > ) > > > > > > What are the benefits of this? > > > > Labels allow to filter pull requests, so we can get a view of all > approved > > pull requests, to merge them (after a final review :) ) > > > > More senior members of the community can focus on approving consensus and > > architecture of pull requests, while newer members of the community can > > focus on “just” reviewing the code quality. > > > > > > If nobody objects here, I will activate this new feature in the coming > > days. > > > > > > > > On Wed, Feb 13, 2019 at 10:29 AM Robert Metzger <rmetz...@apache.org> > > wrote: > > > >> Hey all, > >> > >> the flinkbot has been active for a week now, and I hope the initial > >> hiccups have been resolved :) > >> > >> I wanted to start this as a permanent thread to discuss problems and > >> improvements with the bot. > >> > >> *So please post here if you have questions, problems or ideas how to > >> improve it!* > >> > > >
