Hi Xuefu, Thanks for the feedback. I think JVM is used as we don't need to distinguish scala/java based function for now. But as DDL is an important interface for Flink users. I think we should make it extendable for the future. As you said, It is JAVA and SCALA are in the LANGUAGE level rather than JVM. Given I think we should change it to JAVA.
For the "SHOW FUNCTIONS" and "ALTER FUNCTION", it is my mistake. Bowen actually aligned with me to include it. I just added what is implemented in m previous PR https://github.com/apache/flink/pull/9689. The implementation plan will be like this 1) the existing PR will be updated to align with the new "CREATE FUNCTION" and "DROP FUNCTION" 2) Another PR will be created to focus on "SHOW FUNCTIONS" and "ALTER FUNCTION". I updated the FLIP-79 <https://docs.google.com/document/d/16kkHlis80s61ifnIahCj-0IEdy5NJ1z-vGEJd_JuLog/edit#> doc, please review one more time. Best Regards Peter Huang On Fri, Nov 8, 2019 at 12:12 PM Xuefu Z <usxu...@gmail.com> wrote: > Hi Peter, > > Thanks for driving this. I'm all-in for this. However, as I read the latest > FLIP, I have a couple of questions/comments: > > 1. It seems that "JVM" is proposed as a language type in parallel to > python. I'm not sure that's very intuitive. JVM stands for "java virtual > machine", so the language is really "JAVA", correct? I know "scala" is also > a language which can be generate java byte code that JVM can execute. > > 2. In the flip, "SHOW FUNCTIONS" and "ALTER FUNCTION" are mentioned but I > don't see there is any implementation plan, either in 1.10 or beyond. I > think we could have more clarification on those. > > Thanks, > Xuefu > > On Fri, Nov 8, 2019 at 10:36 AM Bowen Li <bowenl...@gmail.com> wrote: > > > Peter and I went thru the details and defined scope/plan for 1.10 offline > > in the last few days. +1 (binding) from my side. > > > > On Fri, Nov 8, 2019 at 12:55 AM Terry Wang <zjuwa...@gmail.com> wrote: > > > > > Thanks Peter driving on this. LGTM for 1.10 release feature. > > > > > > +1 from my side. (non-binding) > > > > > > Best, > > > Terry Wang > > > > > > > > > > > > > 2019年11月8日 13:20，Peter Huang <huangzhenqiu0...@gmail.com> 写道： > > > > > > > > Dear All, > > > > > > > > I would like to start the vote for 1.10 release features in FLIP-79 > [1] > > > > which is discussed and research consensus in the discussion thread > [2]. > > > For > > > > the advanced feature, such as loading function from remote resources, > > > > support scala/python function, we will have the further discussion > > after > > > > release 1.10. > > > > > > > > The vote will be open for at least 72 hours. If the voting passes, I > > will > > > > close it by 2019-11-10 14:00 UTC. > > > > > > > > [1] > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-79+Flink+Function+DDL+Support > > > > [2] > > > > > > > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Discussion-FLIP-79-Flink-Function-DDL-Support-td33965.html > > > > > > > > Best Regards > > > > Peter Huang > > > > > > > > > > > -- > Xuefu Zhang > > "In Honey We Trust!" >
