Hi Dawid, In general, I agree we should keep separate FLIPs when possible, if they each have some good scope and are decoupled. This one might hardly qualify for a FLIP because the scope is quite small and straight forward, and can be an overkill for FLIP itself. It's also a bit special as the MVP is release (1.10) driven, to deliver a basic e2e experience.
I'm also ok to have separate FLIP for such work item in the future if anyone feels strong about it. Thanks, Bowen On Tue, Nov 19, 2019 at 12:11 AM Dawid Wysakowicz <dwysakow...@apache.org> wrote: > Hi, > > Thank you for your answers and updating the WIKI. > > @Bowen Thank you for updating the wiki page and stepping up for > shepherding the FLIP. > > Just wanted to raise a slight concern if it is possible to accept a FLIP > partially according to our FLIP process. From what I know so far we were > rather splitting a FLIP into multiple ones if we wanted to adapt only a > part of it. I have not followed all the FLIPs though so maybe I missed > something. If it was not discussed I think it would be good to have a > clarification on such process. What do you think? > > @Peter no worries. Thank you for updating the tickets. I think it is safe > for me to say that if you need some help, e.g. a task assignment ;) you can > reach out through the jira to Bowen. > > Best, > > Dawid > > > On 19/11/2019 00:15, Bowen Li wrote: > > Hi Dawid, > > As title of this thread says, only features related to 1.10 release (MVP) > is accepted, and the other part is still under discussion. I updated the > FLIP's status field to reflect that. Also added it to > https://cwiki.apache.org/confluence/display/FLINK/Flink+Improvement+Proposals > > I will help to shepherd this effort in 1.10 release. > > Thanks, > Bowen > > On Mon, Nov 18, 2019 at 8:59 AM Peter Huang <huangzhenqiu0...@gmail.com> > wrote: > >> Hi David, >> >> Sorry for my misbehavior. FLINK-7151 should be the parent tickets of the >> function DDL effort. I recently created several tickets of it, currently >> including >> https://issues.apache.org/jira/browse/FLINK-14055 >> https://issues.apache.org/jira/browse/FLINK-14711 >> https://issues.apache.org/jira/browse/FLINK-14837 >> https://issues.apache.org/jira/browse/FLINK-14841 >> >> For the FLIP status, I think probably Bowen can add more context here. >> >> Best Regards >> Peter Huang >> >> >> >> >> >> >> >> >> On Mon, Nov 18, 2019 at 5:04 AM Dawid Wysakowicz <dwysakow...@apache.org> >> wrote: >> >>> Hey, >>> >>> I've just realized this FLIP was accepted but it was not reflected in >>> the wiki page. >>> >>> Moreover I could not find a single jira issue that would link to the >>> FLIP. I've seen though a few other issues and PRs being opened regarding >>> this FLIP (FLINK-7151?, FLINK-14837, FLINK-14055). I was also a bit >>> confused with the relationship between these issues and e.g. >>> FLINK-10232. I tried to clarify a bit the way I understood it, but maybe >>> somebody more familiar with the whole story could improve it further. >>> >>> Could some of the committers that voted on this proposal help with a bit >>> of shepherding? >>> >>> Best, >>> >>> Dawid >>> >>> On 12/11/2019 07:59, Yu Li wrote: >>> > Thanks Bowen and Peter! Great to know. >>> > >>> > Best Regards, >>> > Yu >>> > >>> > >>> > On Tue, 12 Nov 2019 at 13:38, Peter Huang <huangzhenqiu0...@gmail.com> >>> > wrote: >>> > >>> >> Thank you in advance. Once the PR is done from my side, I will @ you >>> and >>> >> yu for review. >>> >> >>> >> On Mon, Nov 11, 2019 at 9:15 PM Bowen Li <bowenl...@gmail.com> wrote: >>> >> >>> >>> Thanks Peter! I assigned the ticket to you, and I can help with >>> reviewing >>> >>> and merging PRs of this FLIP. >>> >>> >>> >>> Ccing 1.10 release manager Yu that we are on track of FLIP-79. >>> >>> >>> >>> Cheers, >>> >>> Bowen >>> >>> >>> >>> On Mon, Nov 11, 2019 at 9:03 PM Peter Huang < >>> huangzhenqiu0...@gmail.com> >>> >>> wrote: >>> >>> >>> >>>> Thanks, everyone for joining the discussion and giving feedback!. >>> The >>> >>>> voting time for FLIP-79 has passed. I'm closing the vote now. >>> >>>> >>> >>>> There were seven +1 votes, 3 of which are binding: >>> >>>> - Bowen Li (binding) >>> >>>> - Kurt Yong (binding) >>> >>>> - Shuyi Chen (binding) >>> >>>> >>> >>>> - Terry Wang (non-binding) >>> >>>> - Xuefu Zhang (non-binding) >>> >>>> - Vino Yang (non-binding) >>> >>>> - Jingsong Lee (non-binding) >>> >>>> >>> >>>> There were no disapproving votes. Thus, FLIP-79 has been accepted. >>> Now, >>> >>> we >>> >>>> agreed on the function DDL syntax as listed on the FLIP >>> >>>> and also the initial execution plan for release 1.10. Currently, I >>> will >>> >>>> mainly work on these two Jira tickets. >>> >>>> >>> >>>> 1) https://issues.apache.org/jira/browse/FLINK-7151 >>> >>>> 2) https://issues.apache.org/jira/browse/FLINK-14711 >>> >>>> >>> >>>> >>> >>>> >>> >>>> Best Regards >>> >>>> Peter Huang >>> >>>> >>> >>>> >>> >>>> Best Regards >>> >>>> Peter Huang >>> >>>> >>> >>>> On Mon, Nov 11, 2019 at 7:42 PM Jingsong Li <jingsongl...@gmail.com >>> > >>> >>>> wrote: >>> >>>> >>> >>>>> +1 (non-binding) >>> >>>>> >>> >>>>> Best, >>> >>>>> Jingsong Lee >>> >>>>> >>> >>>>> On Tue, Nov 12, 2019 at 9:49 AM vino yang <yanghua1...@gmail.com> >>> >>> wrote: >>> >>>>>> +1 (non-binding) >>> >>>>>> >>> >>>>>> Best, >>> >>>>>> Vino >>> >>>>>> >>> >>>>>> Xuefu Z <usxu...@gmail.com> 于2019年11月12日周二 上午3:27写道： >>> >>>>>> >>> >>>>>>> +1 (non-binding) >>> >>>>>>> >>> >>>>>>> On Mon, Nov 11, 2019 at 9:54 AM Shuyi Chen <suez1...@gmail.com> >>> >>>> wrote: >>> >>>>>>>> +1 (binding) >>> >>>>>>>> >>> >>>>>>>> On Sat, Nov 9, 2019 at 11:17 PM Kurt Young <ykt...@gmail.com> >>> >>>> wrote: >>> >>>>>>>>> +1 (binding) >>> >>>>>>>>> >>> >>>>>>>>> Best, >>> >>>>>>>>> Kurt >>> >>>>>>>>> >>> >>>>>>>>> >>> >>>>>>>>> On Sun, Nov 10, 2019 at 12:25 PM Peter Huang < >>> >>>>>>> huangzhenqiu0...@gmail.com >>> >>>>>>>>> wrote: >>> >>>>>>>>> >>> >>>>>>>>>> Hi Yu, >>> >>>>>>>>>> >>> >>>>>>>>>> Thanks for your reminder about the timeline of delivering >>> >>> the >>> >>>>> basic >>> >>>>>>>>>> function DDL in release 1.10. >>> >>>>>>>>>> As I replied to Xuefu, the "CREATE FUNCTION" and "DROP >>> >>>> FUNCTION" >>> >>>>>> can >>> >>>>>>>>>> relatively easy achieve by revising the existing PR. >>> >>>>>>>>>> Definitely, I probably need to start to work on a basic >>> >>> version >>> >>>>> of >>> >>>>>> PR >>> >>>>>>>> for >>> >>>>>>>>>> "ALTER FUNCTION" and "SHOW FUNCTIONS". >>> >>>>>>>>>> Please let me know if you have any suggestion to better >>> >>> align >>> >>>> the >>> >>>>>>>>> timeline >>> >>>>>>>>>> of the ongoing catalog related efforts. >>> >>>>>>>>>> >>> >>>>>>>>>> Best Regards >>> >>>>>>>>>> Peter Huang >>> >>>>>>>>>> >>> >>>>>>>>>> >>> >>>>>>>>>> On Sat, Nov 9, 2019 at 7:26 PM Yu Li <car...@gmail.com> >>> >>> wrote: >>> >>>>>>>>>>> Thanks for driving this Peter! >>> >>>>>>>>>>> >>> >>>>>>>>>>> I agree it would be great if we could include this >>> >>> feature in >>> >>>>>> 1.10. >>> >>>>>>>>>>> However, FWIW, since we are following the time-based >>> >>> release >>> >>>>>> policy >>> >>>>>>>> [1] >>> >>>>>>>>>> and >>> >>>>>>>>>>> 1.10 release is approaching its feature freeze (planned >>> >>> to be >>> >>>>> at >>> >>>>>>> the >>> >>>>>>>>> end >>> >>>>>>>>>> of >>> >>>>>>>>>>> November) [2], I'm a little bit concerned about the >>> >>> schedule. >>> >>>>>>>>>>> [1] >>> >>>> >>> https://cwiki.apache.org/confluence/display/FLINK/Time-based+releases >>> >>>>>>>>>>> [2] >>> >>>>>>>>>>> >>> >>>>>>>>>>> >>> >>> >>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Features-for-Apache-Flink-1-10-td32824.html >>> >>>>>>>>>>> Best Regards, >>> >>>>>>>>>>> Yu >>> >>>>>>>>>>> >>> >>>>>>>>>>> >>> >>>>>>>>>>> On Sat, 9 Nov 2019 at 04:12, Xuefu Z <usxu...@gmail.com> >>> >>>>> wrote: >>> >>>>>>>>>>>> Hi Peter, >>> >>>>>>>>>>>> >>> >>>>>>>>>>>> Thanks for driving this. I'm all-in for this. However, >>> >>> as I >>> >>>>>> read >>> >>>>>>>> the >>> >>>>>>>>>>> latest >>> >>>>>>>>>>>> FLIP, I have a couple of questions/comments: >>> >>>>>>>>>>>> >>> >>>>>>>>>>>> 1. It seems that "JVM" is proposed as a language type in >>> >>>>>> parallel >>> >>>>>>>> to >>> >>>>>>>>>>>> python. I'm not sure that's very intuitive. JVM stands >>> >>> for >>> >>>>>> "java >>> >>>>>>>>>> virtual >>> >>>>>>>>>>>> machine", so the language is really "JAVA", correct? I >>> >>> know >>> >>>>>>> "scala" >>> >>>>>>>>> is >>> >>>>>>>>>>> also >>> >>>>>>>>>>>> a language which can be generate java byte code that JVM >>> >>>> can >>> >>>>>>>> execute. >>> >>>>>>>>>>>> 2. In the flip, "SHOW FUNCTIONS" and "ALTER FUNCTION" >>> >>> are >>> >>>>>>> mentioned >>> >>>>>>>>>> but I >>> >>>>>>>>>>>> don't see there is any implementation plan, either in >>> >>> 1.10 >>> >>>> or >>> >>>>>>>>> beyond. I >>> >>>>>>>>>>>> think we could have more clarification on those. >>> >>>>>>>>>>>> >>> >>>>>>>>>>>> Thanks, >>> >>>>>>>>>>>> Xuefu >>> >>>>>>>>>>>> >>> >>>>>>>>>>>> On Fri, Nov 8, 2019 at 10:36 AM Bowen Li < >>> >>>>> bowenl...@gmail.com> >>> >>>>>>>>> wrote: >>> >>>>>>>>>>>>> Peter and I went thru the details and defined >>> >>> scope/plan >>> >>>>> for >>> >>>>>>> 1.10 >>> >>>>>>>>>>> offline >>> >>>>>>>>>>>>> in the last few days. +1 (binding) from my side. >>> >>>>>>>>>>>>> >>> >>>>>>>>>>>>> On Fri, Nov 8, 2019 at 12:55 AM Terry Wang < >>> >>>>>> zjuwa...@gmail.com >>> >>>>>>>>>> wrote: >>> >>>>>>>>>>>>>> Thanks Peter driving on this. LGTM for 1.10 release >>> >>>>>> feature. >>> >>>>>>>>>>>>>> +1 from my side. (non-binding) >>> >>>>>>>>>>>>>> >>> >>>>>>>>>>>>>> Best, >>> >>>>>>>>>>>>>> Terry Wang >>> >>>>>>>>>>>>>> >>> >>>>>>>>>>>>>> >>> >>>>>>>>>>>>>> >>> >>>>>>>>>>>>>>> 2019年11月8日 13:20，Peter Huang < >>> >>>>> huangzhenqiu0...@gmail.com >>> >>>>>>>> 写道： >>> >>>>>>>>>>>>>>> Dear All, >>> >>>>>>>>>>>>>>> >>> >>>>>>>>>>>>>>> I would like to start the vote for 1.10 release >>> >>>>> features >>> >>>>>> in >>> >>>>>>>>>> FLIP-79 >>> >>>>>>>>>>>> [1] >>> >>>>>>>>>>>>>>> which is discussed and research consensus in the >>> >>>>>> discussion >>> >>>>>>>>>> thread >>> >>>>>>>>>>>> [2]. >>> >>>>>>>>>>>>>> For >>> >>>>>>>>>>>>>>> the advanced feature, such as loading function >>> >>> from >>> >>>>>> remote >>> >>>>>>>>>>> resources, >>> >>>>>>>>>>>>>>> support scala/python function, we will have the >>> >>>> further >>> >>>>>>>>>> discussion >>> >>>>>>>>>>>>> after >>> >>>>>>>>>>>>>>> release 1.10. >>> >>>>>>>>>>>>>>> >>> >>>>>>>>>>>>>>> The vote will be open for at least 72 hours. If >>> >>> the >>> >>>>>> voting >>> >>>>>>>>>> passes, >>> >>>>>>>>>>> I >>> >>>>>>>>>>>>> will >>> >>>>>>>>>>>>>>> close it by 2019-11-10 14:00 UTC. >>> >>>>>>>>>>>>>>> >>> >>>>>>>>>>>>>>> [1] >>> >>>>>>>>>>>>>>> >>> >>> >>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-79+Flink+Function+DDL+Support >>> >>>>>>>>>>>>>>> [2] >>> >>>>>>>>>>>>>>> >>> >>> >>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Discussion-FLIP-79-Flink-Function-DDL-Support-td33965.html >>> >>>>>>>>>>>>>>> Best Regards >>> >>>>>>>>>>>>>>> Peter Huang >>> >>>>>>>>>>>>>> >>> >>>>>>>>>>>> >>> >>>>>>>>>>>> -- >>> >>>>>>>>>>>> Xuefu Zhang >>> >>>>>>>>>>>> >>> >>>>>>>>>>>> "In Honey We Trust!" >>> >>>>>>>>>>>> >>> >>>>>>> >>> >>>>>>> -- >>> >>>>>>> Xuefu Zhang >>> >>>>>>> >>> >>>>>>> "In Honey We Trust!" >>> >>>>>>> >>> >>>>> >>> >>>>> -- >>> >>>>> Best, Jingsong Lee >>> >>>>> >>> >>>
