I'm also in favor of dropping the bat scripts. I can hardly image people using Flink Windows deployment in their production. But maybe throwing a survey on the user ML to double check on that?
Thank you~ Xintong Song On Thu, Feb 20, 2020 at 10:28 AM Yang Wang <danrtsey...@gmail.com> wrote: > I tend to drop the windows bat script to start/stop the cluster. Since > there > are various windows versions(e.g. xp, win7, win10, etc.) and do not have > sensational compatibility. Also we do not have the e2e tests to guarantee > the scripts work well. > > On the other hand, i completely agree that local deployment, especially in > the IDE, should work on windows. For standalone deployment, i think using > the docker is a good choice. I think many windows users are also using > docker. For Yarn/K8s deployment, i am not sure whether we need to support > to submit a Flink session/per-job cluster from windows machine. > > > Best, > Yang > > Chesnay Schepler <ches...@apache.org> 于2020年2月20日周四 上午12:15写道： > > > Note that with FLINK-15925 we effectively broke the start-cluster.bat > > script in 1.10. > > > > Overall, I would be fine with dropping the .bat scripts because they are > > a big maintenance problem for us. > > We don't have anyone using these scripts regularly on our end (even I > > don't). > > If there were a way to unify the unix/windows scripts I would be all > > ears, but this doesn't seem possible without lots and lots of branches. > > > > However, we should definitely ensure that Flink continues to work in the > > IDE on windows for training/demo purposes. > > > > As for CI, with the new Azure setup this may actually be feasible now > > from a CI budged perspective. But it would require a fair upfront time > > investment to fix failing tests or adding assumptions for failing tests. > > That said, this would have some nice benefits for finding resource > > leaks, particularly in the filesystem. > > > > On 19/02/2020 16:46, Aljoscha Krettek wrote: > > > Hi, > > > > > > the background is this series of Jira Issues and PRs around extending > > > the .bat scripts for windows: > > > https://issues.apache.org/jira/browse/FLINK-5333. > > > > > > I would like to resolve this, by either closing the Jira Issues as > > > "Won't Do" or finally merging these PRs. The questions I have are: > > > > > > - Should we add more full-featured (complicated?) windows scripts > > > that are essentially re-implementations of our existing "unix" scripts? > > > - Would windows users use these or would they, by now, use the linux > > > subsystem for windows or cygwin? > > > - Should we even remove the existing .bat scripts that we have? > > > > > > Maintaining the windows scripts is hard because we only have one (I > > > think, Chesnay) developer on windows and no CI for windows. > > > > > > What do you think? > > > > > > Best, > > > Aljoscha > > > > > > > >
