After discussing FLINK-18581 with @Xintong Song <tonysong...@gmail.com> offline, it seems that it doesn't need to block 1.11.1. Because users can switch to use another version of JDK as a workaround. Besides, this might not be a trivial issue, we may need more time to come up with a clean solution and check compatibility problems for other JDK versions. Therefore, I suggest downgrading the priority of FLINK-18581, and not block 1.11.1 release.
What do you think? @Dian Fu <dia...@apache.org> , @Chesnay Schepler <ches...@apache.org> , @Xintong Song <tonysong...@gmail.com> Best, Jark On Mon, 13 Jul 2020 at 18:16, Dian Fu <dian0511...@gmail.com> wrote: > Thanks! It makes sense to include FLINK-18573 and FLINK-18581 in 1.11.1. > > > 在 2020年7月13日，下午5:52，Chesnay Schepler <ches...@apache.org> 写道： > > > > It would be good to fix FLINK-18581 as well. > > > > On 13/07/2020 11:14, Jark Wu wrote: > >> Hi Chesnay, > >> > >> As discussed in the thread, 1.11.1 is a quick fix release, not a normal > fix > >> release process. This is in order to deliver a complete feature for > users > >> to try out 1.11 ASAP. > >> Actually, we already waited for the bugs for one week, and we have > received > >> some blocker issues reported by users (FLINK-18544, FLINK-18573). > >> Personally, I suggest not to wait more time to collect bugs, because we > >> can't wait until all the bugs are found and this will delay the feature > >> delivery again. > >> We can launch another patch release at any time after 1.11.1 if needed. > >> > >> Regarding FLINK-18573, I think it definitely is a blocker issue and > >> considering we haven't started the first RC. I think it makes sense to > wait > >> for this. > >> > >> Best, > >> Jark > >> > >> > >> On Mon, 13 Jul 2020 at 16:42, Chesnay Schepler <ches...@apache.org> > wrote: > >> > >>> Given that we are _just now_ starting to get bug reports, shouldn't we > >>> wait a bit longer with the next release? > >>> > >>> On 13/07/2020 10:30, Yun Tang wrote: > >>>> Hi > >>>> > >>>> If we decide to release Flink-1.11.1, I suggest to include fix for > >>> FLINK-18573 [1] as current influxdb metrics reporter is totally broken > from > >>> Flink-1.11 under current plugins mechanism. > >>>> [1] https://issues.apache.org/jira/browse/FLINK-18573 > >>>> > >>>> Best > >>>> Yun Tang > >>>> ________________________________ > >>>> From: Dian Fu <dian0511...@gmail.com> > >>>> Sent: Monday, July 13, 2020 15:06 > >>>> To: Leonard Xu <xbjt...@gmail.com> > >>>> Cc: dev <dev@flink.apache.org>; Chesnay Schepler <ches...@apache.org > >; > >>> Timo Walther <j...@apache.org>; programg...@163.com < > programg...@163.com> > >>>> Subject: Re: [DISCUSS] Releasing Flink 1.11.1 soon? > >>>> > >>>> Thanks a lot for the confirmation, Leonard! > >>>> > >>>>> 在 2020年7月13日，上午11:37，Leonard Xu <xbjt...@gmail.com> 写道： > >>>>> > >>>>> Thanks Dian for the work, I’m fine with do not include FLINK-17726 in > >>> this bug-fix version. > >>>>> Best, > >>>>> Leonard Xu > >>>>> > >>>>>> 在 2020年7月13日，11:31，Dian Fu <dian0511...@gmail.com> 写道： > >>>>>> > >>>>>> Hi all, > >>>>>> > >>>>>> I have gone over the issues mentioned in this thread and most issues > >>> have already been resolved. Thanks you all for the quick fix! > >>>>>> Currently there are still the following mentioned issues are open: > >>>>>> - FLINK-17075: Add task status reconciliation between TM and JM > >>> (@Chesnay) > >>>>>> - FLINK-18477: ChangelogSocketExample does not work (@Timo) > >>>>>> > >>>>>> Regarding to FLINK-17726, I confirmed with @Nicholas Jiang and it > will > >>> not be included in 1.11.1. @Leonard Xu, do you have any concerns? > >>>>>> Please free free to let me know if there are any other issues you'd > >>> like to be included in 1.11.1. I will prepare the first RC once all the > >>> mentioned issues are resolved. > >>>>>> Thanks, > >>>>>> Dian > >>>>>> > >>>>>>> 在 2020年7月10日，上午11:06，godfrey he <godfre...@gmail.com> 写道： > >>>>>>> > >>>>>>> +1 for a quick release to fix those blocker/critical bugs. > >>>>>>> > >>>>>>> Best, > >>>>>>> Godfrey > >>>>>>> > >>>>>>> Congxian Qiu <qcx978132...@gmail.com> 于2020年7月10日周五 上午10:30写道： > >>>>>>> > >>>>>>>> +1 for a quick bug fix release for 1.11 > >>>>>>>> > >>>>>>>> Best, > >>>>>>>> Congxian > >>>>>>>> > >>>>>>>> > >>>>>>>> Yu Li <car...@gmail.com> 于2020年7月10日周五 上午9:37写道： > >>>>>>>> > >>>>>>>>> +1, thanks Jark for bringing this up and Dian for volunteering as > >>> our > >>>>>>>>> release manager. > >>>>>>>>> > >>>>>>>>> Best Regards, > >>>>>>>>> Yu > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> On Fri, 10 Jul 2020 at 09:29, Hequn Cheng <he...@apache.org> > wrote: > >>>>>>>>> > >>>>>>>>>> +1 for a quick bug fix release and Dian as the release manager. > >>>>>>>>>> > >>>>>>>>>> Best, > >>>>>>>>>> Hequn > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> On Thu, Jul 9, 2020 at 9:22 PM Dian Fu <dian0511...@gmail.com> > >>> wrote: > >>>>>>>>>>> Hi Jark, > >>>>>>>>>>> > >>>>>>>>>>> Thanks for offering the help. It would definitely be helpful. > >>>>>>>>>>> > >>>>>>>>>>> Regards, > >>>>>>>>>>> Dian > >>>>>>>>>>> > >>>>>>>>>>>> 在 2020年7月9日，下午8:54，Benchao Li <libenc...@apache.org> 写道： > >>>>>>>>>>>> > >>>>>>>>>>>> +1 for a quick bug fix release for 1.11 > >>>>>>>>>>>> > >>>>>>>>>>>> Aljoscha Krettek <aljos...@apache.org> 于2020年7月9日周四 下午8:11写道： > >>>>>>>>>>>> > >>>>>>>>>>>>> +1 > >>>>>>>>>>>>> > >>>>>>>>>>>>> I'd also be in favour of releasing a 1.11.1 quickly > >>>>>>>>>>>>> > >>>>>>>>>>>>> Aljoscha > >>>>>>>>>>>>> > >>>>>>>>>>>>> On 09.07.20 13:57, Jark Wu wrote: > >>>>>>>>>>>>>> Hi Dian, > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> Glad to hear that you want to be the release manager of > Flink > >>>>>>>>> 1.11.1. > >>>>>>>>>>>>>> I am very willing to help you with the final steps of the > >>> release > >>>>>>>>>>>>> process. > >>>>>>>>>>>>>> Best, > >>>>>>>>>>>>>> Jark > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> On Thu, 9 Jul 2020 at 17:57, Jingsong Li < > >>> jingsongl...@gmail.com > >>>>>>>>>>> wrote: > >>>>>>>>>>>>>>> FLINK-18461 is really a blocker for the CDC feature. > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> So +1 for releasing Flink 1.11.1 soon. > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> Best, > >>>>>>>>>>>>>>> Jingsong > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> On Thu, Jul 9, 2020 at 5:34 PM jincheng sun < > >>>>>>>>>> sunjincheng...@gmail.com > >>>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> Thanks for bring up this discussion Jark. > >>>>>>>>>>>>>>>> +1, looking forward the first bugfix version of Flink > 1.11. > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> Best, > >>>>>>>>>>>>>>>> Jincheng > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> Dian Fu <dian0511...@gmail.com> 于2020年7月9日周四 下午5:28写道： > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> Thanks Jark for bringing up this discussion. I also > noticed > >>>>>>>> that > >>>>>>>>>>> there > >>>>>>>>>>>>>>>> are > >>>>>>>>>>>>>>>>> already users trying out the CDC feature and so it makes > >>> sense > >>>>>>>>> to > >>>>>>>>>>>>> have a > >>>>>>>>>>>>>>>>> quick 1.11.1 release. > >>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> I would volunteer as the release manager of 1.11.1 if we > >>>>>>>> finally > >>>>>>>>>>>>> decide > >>>>>>>>>>>>>>>> to > >>>>>>>>>>>>>>>>> have a quick release. Also +1 to create the first RC on > next > >>>>>>>>>> Monday. > >>>>>>>>>>>>>>>>> Thanks, > >>>>>>>>>>>>>>>>> Dian > >>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> 在 2020年7月9日，下午3:55，Dawid Wysakowicz < > >>> dwysakow...@apache.org> > >>>>>>>>> 写道： > >>>>>>>>>>>>>>>>>> I do agree it would be beneficial to have the 1.11.1 > rather > >>>>>>>>> soon. > >>>>>>>>>>>>>>>>>> Personally additionally to Jark's list I'd like to see: > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> FLINK-18419 Can not create a catalog from user jar > >>>>>>>>>>>>>>>>>> (https://issues.apache.org/jira/browse/FLINK-18419) > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> incluedd. It has a PR already. > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> Best, > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> Dawid > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> On 09/07/2020 09:51, Leonard Xu wrote: > >>>>>>>>>>>>>>>>>>> Hi, Jark > >>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>> Thanks fro bringing this discussion. > >>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>> We canceled the blocker priority of FLINK-18461 when > >>> release > >>>>>>>>>> Flink > >>>>>>>>>>>>>>>>> 1.11.0 from time consideration, IIRC, the majority of us > >>>>>>>> agreed > >>>>>>>>> to > >>>>>>>>>>>>> have > >>>>>>>>>>>>>>>> a > >>>>>>>>>>>>>>>>> timely 1.11.1 in the vote mail of Flink 1.11.0. > >>>>>>>>>>>>>>>>>>> And I have noticed some user voice[1][2] that they’re > >>> using > >>>>>>>>> CDC > >>>>>>>>>>>>>>>> feature > >>>>>>>>>>>>>>>>> in mail list and offline communication with community > user, > >>> I > >>>>>>>>>> think > >>>>>>>>>>>>> the > >>>>>>>>>>>>>>>>> following notable issues should be included in 1.11.1: > >>>>>>>>>>>>>>>>>>> - FLINK-18461 Changelog source can't be insert into > upsert > >>>>>>>>> sink > >>>>>>>>>>>>>>>>>>> - FLINK-18426 Incompatible deprecated key type for > >>>>>>>>> registration > >>>>>>>>>>>>>>>> cluster > >>>>>>>>>>>>>>>>>>> - FLINK-18434 Can not select fields with JdbcCatalog > >>>>>>>>>>>>>>>>>>> - FLINK-17726 Scheduler should take care of tasks > directly > >>>>>>>>>>> canceled > >>>>>>>>>>>>>>>> by > >>>>>>>>>>>>>>>>> TaskManager > >>>>>>>>>>>>>>>>>>> - FLINK-17075 Add task status reconciliation between TM > >>> and > >>>>>>>> JM > >>>>>>>>>>>>>>>>>>> So, +1 to prepare a quick bug-fix version from my > side. > >>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>> Best, > >>>>>>>>>>>>>>>>>>> Leonard Xu > >>>>>>>>>>>>>>>>>>> [1] user: > >>> > http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Flip-105-can-the-debezium-canal-SQL-sink-to-database-directly-td36275.html#a36306 > >>>>>>>>>>>>>>>>> < > >>>>>>>>>>>>>>>>> > >>> > http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Flip-105-can-the-debezium-canal-SQL-sink-to-database-directly-td36275.html#a36306 > >>>>>>>>>>>>>>>>>>> [2] user-zh: > >>> > http://apache-flink.147419.n8.nabble.com/flink-1-11-cdc-flink-sql-kafka-topic-tt4567.html#a4590 > >>>>>>>>>>>>>>>>> < > >>>>>>>>>>>>>>>>> > >>> > http://apache-flink.147419.n8.nabble.com/flink-1-11-cdc-flink-sql-kafka-topic-tt4567.html#a4590 > >>>>>>>>>>>>>>>>>>>> 在 2020年7月9日，11:12，Jark Wu <imj...@gmail.com> 写道： > >>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>> Besides, it would be great if we can figure out the > >>>>>>>>> performance > >>>>>>>>>>>>>>>>> regression > >>>>>>>>>>>>>>>>>>>> Thomas reported before. > >>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>> Do you know what's the status now? @zhijiang < > >>>>>>>>>>>>>>>>> wangzhijiang...@aliyun.com> > >>>>>>>>>>>>>>>>>>>> @Thomas > >>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>> Best, > >>>>>>>>>>>>>>>>>>>> Jark > >>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>> On Thu, 9 Jul 2020 at 11:10, Jark Wu < > imj...@gmail.com> > >>>>>>>>> wrote: > >>>>>>>>>>>>>>>>>>>>> Hi everyone, > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>> As discussed in the voting thread of 1.11.0-RC4 [1], > we > >>>>>>>>> found > >>>>>>>>>> a > >>>>>>>>>>>>>>>>> blocker > >>>>>>>>>>>>>>>>>>>>> issue about the CDC feature [1]. > >>>>>>>>>>>>>>>>>>>>> Considering this is a new kind of connector, we don't > >>> want > >>>>>>>>> to > >>>>>>>>>>>>> block > >>>>>>>>>>>>>>>>> the > >>>>>>>>>>>>>>>>>>>>> ready-to-publish RC4 and prefer to have an > immediately > >>>>>>>>> 1.11.1 > >>>>>>>>>>>>>>>> release. > >>>>>>>>>>>>>>>>>>>>> Therefore, I would like to start the discussion about > >>>>>>>>>> releasing > >>>>>>>>>>>>>>>> 1.11.1 > >>>>>>>>>>>>>>>>>>>>> soon, to deliver a complete CDC feature. > >>>>>>>>>>>>>>>>>>>>> We can also release some notable bug fixes found in > >>> these > >>>>>>>>>> days. > >>>>>>>>>>>>>>>> But I > >>>>>>>>>>>>>>>>>>>>> suggest not to wait too long to collect/fix bugs, > >>>>>>>>>>>>>>>>>>>>> otherwise it will delay the feature delivery again, > we > >>> can > >>>>>>>>>>> launch > >>>>>>>>>>>>>>>>> another > >>>>>>>>>>>>>>>>>>>>> patch release after that if needed. > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>> Most notable bug fixes so far are: > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>> - FLINK-18461 Changelog source can't be insert into > >>> upsert > >>>>>>>>>> sink > >>>>>>>>>>>>>>>>>>>>> - FLINK-18426 Incompatible deprecated key type for > >>>>>>>>>> registration > >>>>>>>>>>>>>>>>> cluster > >>>>>>>>>>>>>>>>>>>>> options > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>> Furthermore, I think it would be better if we can fix > >>>>>>>> these > >>>>>>>>>>> issues > >>>>>>>>>>>>>>>> in > >>>>>>>>>>>>>>>>>>>>> 1.11.1: > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>> - FLINK-18434 Can not select fields with JdbcCatalog > (PR > >>>>>>>>>> opened) > >>>>>>>>>>>>>>>>>>>>> - FLINK-18520 New Table Function type inference fails > >>> (PR > >>>>>>>>>>> opened) > >>>>>>>>>>>>>>>>>>>>> - FLINK-18477 ChangelogSocketExample does not work > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>> I'd like to suggest creating the first RC next > Monday. > >>>>>>>> What > >>>>>>>>> do > >>>>>>>>>>> you > >>>>>>>>>>>>>>>>> think? > >>>>>>>>>>>>>>>>>>>>> If there are any concerns or missing blocker issues > need > >>>>>>>> to > >>>>>>>>> be > >>>>>>>>>>>>>>>> fixed > >>>>>>>>>>>>>>>>> in > >>>>>>>>>>>>>>>>>>>>> 1.11.1, please let me know. Thanks. > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>> Best, > >>>>>>>>>>>>>>>>>>>>> Jark > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>> [1]: > >>>>>>>>>>>>>>>>>>>>> > >>> > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/VOTE-Release-1-11-0-release-candidate-4-tp42829p42858.html > >>>>>>>>>>>>>>>>>>>>> [2]: > https://issues.apache.org/jira/browse/FLINK-18461 > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> -- > >>>>>>>>>>>>>>> Best, Jingsong Lee > >>>>>>>>>>>>>>> > >>>>>>>>>>>> -- > >>>>>>>>>>>> > >>>>>>>>>>>> Best, > >>>>>>>>>>>> Benchao Li > >>> > > > >
