Thanks Jing and Gordon, I have closed the pr https://github.com/apache/flink/pull/21965 and will open a new one for kafka connector
Best, shammon FY On Saturday, March 25, 2023, Ran Tao <chucheng...@gmail.com> wrote: > Thank you Gordon and all the people who have worked on the externalized > kafka implementation. > I have another pr related to Kafka[1]. I will be very appreciative if you > can help me review it in your free time. > > [1] https://github.com/apache/flink-connector-kafka/pull/10 > > Best Regards, > Ran Tao > > > Tzu-Li (Gordon) Tai <tzuli...@apache.org> 于2023年3月24日周五 23:21写道： > > > Thanks Jing! I missed https://github.com/apache/flink/pull/21965 indeed. > > > > Please let us know if anything else was overlooked. > > > > On Fri, Mar 24, 2023 at 8:13 AM Jing Ge <j...@ververica.com.invalid> > > wrote: > > > > > Thanks Gordon for driving this! There is another PR related to Kafka > > > connector: https://github.com/apache/flink/pull/21965 > > > > > > Best regards, > > > Jing > > > > > > On Fri, Mar 24, 2023 at 4:06 PM Tzu-Li (Gordon) Tai < > tzuli...@apache.org > > > > > > wrote: > > > > > > > Hi all, > > > > > > > > Now that Flink 1.17 has been released, and given that we've already > > > synced > > > > the latest Kafka connector code up to Flink 1.17 to the > > > > apache/flink-connector-kafka repo (thanks to Mason and Martijn for > most > > > of > > > > the effort!), we're now in the final step of completely removing the > > > Kafka > > > > connector code from apache/flink:main branch, tracked by FLINK-30859 > > [1]. > > > > > > > > As such, we'd like to ask that no more Kafka connector changes gets > > > merged > > > > to apache/flink:main, effective now. Going forward, all Kafka > connector > > > PRs > > > > should be opened directly against the apache/flink-connector-kafka: > main > > > > branch. > > > > > > > > Meanwhile, there's a couple of "dangling" Kafka connector PRs over > the > > > last > > > > 2 months that is opened against apache/flink:main: > > > > > > > > 1. [FLINK-31305] Propagate producer exceptions outside of mailbox > > > > executor [2] > > > > 2. [FLINK-31049] Add support for Kafka record headers to KafkaSink > > [3] > > > > 3. [FLINK-31262] Move kafka sql connector fat jar test to > > > > SmokeKafkaITCase [4 ] > > > > 4. [hotfix] Add writeTimestamp option to > > > > KafkaRecordSerializationSchemaBuilder [5] > > > > > > > > Apart from 1. [FLINK-31305] which is a critical bug and is already in > > > > review closed to being merged, for the rest we will be reaching out > on > > > the > > > > PRs to ask the authors to close the PR and reopen them against > > > > apache/flink-connector-kafka:main. > > > > > > > > Thanks, > > > > Gordon > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-30859 > > > > [2] https://github.com/apache/flink/pull/22150 > > > > [3] https://github.com/apache/flink/pull/22228 > > > > [4] https://github.com/apache/flink/pull/22060 > > > > [5] https://github.com/apache/flink/pull/22037 > > > > > > > > > >
