I only wanted to have (at least) mvn clean install -DskipTests run, to help the reviews in such a way that the patch * doesn't break the build, * passes checkstyle, * passes RAT checks.
I think, that would save time and cause less frustration for everyone. That would fit in the 50 min time limit, I've checked it on my fork. On Fri, Oct 14, 2016 at 1:29 PM, Hari Shreedharan <[email protected]> wrote: > I think the free version of Travis has a 50 minute limit on the total build > time and last I checked flume full build took longer than that. Is there a > way to workaround that? I think I have a branch somewhere on GitHub that I > experimented with. > > One interesting possibility with Travis is to integrate code coverage > reports into PR builds, which is pretty nice. > On Fri, Oct 14, 2016 at 3:09 AM Attila Simon <[email protected]> wrote: > >> +1 on jenkins, and keeping our build infra as simple and intuitive as >> possible >> If migrating everything - we currently do with Jenkins - to Travis and >> abandon Jenkins than I would be fine with that as well. >> >> >> *Attila Simon* >> Software Engineer >> Email: [email protected] >> >> [image: Cloudera Inc.] >> >> On Fri, Oct 14, 2016 at 10:09 AM, Balazs Donat Bessenyei < >> [email protected]> wrote: >> >> > My primary reason for Travis (vs. Jenkins) was that I have experience >> with >> > it. >> > >> > And it leaves these happy little checkmarks: >> > https://github.com/sebastianbergmann/phpunit/pull/1051/commits on the >> > commits and messages as seen on >> > https://github.com/apache/hive/pull/107 . >> > >> > Jenkins is probably configurable to achieve similar function. However, >> > I have no idea how to do such. (And could not find an example when I >> > did a quick search.) >> > >> > Are there any disadvantages of enabling Travis on Flume? >> > >> > >> > Thank you, >> > >> > Donat >> > >> > On Thu, Oct 13, 2016 at 6:06 PM, Lior Zeno <[email protected]> wrote: >> > > Jenkins can do PRs as well. If we can upgrade Jenkins to 2.0, we will >> be >> > > able to define the build step via Jenkinsfile which becomes very >> similar >> > to >> > > Travis. >> > > Is there any reason to prefer Travis over Jenkins in our case? >> > > >> > > On Thu, Oct 13, 2016 at 7:01 PM, Balazs Donat Bessenyei < >> > [email protected] >> > >> wrote: >> > > >> > >> Hi All, >> > >> >> > >> Having something that checks proposed patches (PR-s especially) >> > >> automatically would help a lot with the development on Flume. >> > >> >> > >> I think, Travis-CI could be an easy solution and (afaik) we'd only >> have >> > to >> > >> ask infra to enable it for us. >> > >> >> > >> Please, let me know your thoughts. >> > >> >> > >> Thank you, >> > >> >> > >> Donat >> > >> >> > >>
