> On 六月 2, 2017, 1:41 p.m., Miklos Csanady wrote: > > flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java > > Line 273 (original), 275 (patched) > > <https://reviews.apache.org/r/59743/diff/1/?file=1740249#file1740249line275> > > > > I would prefer to make it configurable. > > 1000 can be a default.
It should be numThreshold?not retryInterval. Right? > On 六月 2, 2017, 1:41 p.m., Miklos Csanady wrote: > > flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java > > Line 276 (original), 278 (patched) > > <https://reviews.apache.org/r/59743/diff/1/?file=1740249#file1740249line278> > > > > If the readCount reaches numTreshold we could log a warning. > > Or it can trigger a metrics counter. ok, I will log a warning. On 六月 2, 2017, 1:41 p.m., hun shenshi wrote: > > Do you have an idea how to cover this case with a test? > > > > Thank you for this nice contribution. ok. I will think about it. - hun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59743/#review176765 ----------------------------------------------------------- On 六月 2, 2017, 10:09 a.m., hun shenshi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59743/ > ----------------------------------------------------------- > > (Updated 六月 2, 2017, 10:09 a.m.) > > > Review request for Flume. > > > Bugs: FLUME-3101 > https://issues.apache.org/jira/browse/FLUME-3101 > > > Repository: flume-git > > > Description > ------- > > Add a threshold in TaildirSource. Use the threshold to control the number of > reads when a file is written by high frequency. > > > Diffs > ----- > > > flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java > a107a01 > > > Diff: https://reviews.apache.org/r/59743/diff/1/ > > > Testing > ------- > > mvn clean install -DskipTests -> built > > > Thanks, > > hun shenshi > >
