> On 六月 2, 2017, 1:41 p.m., Miklos Csanady wrote:
> > flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java
> > Line 276 (original), 278 (patched)
> > <https://reviews.apache.org/r/59743/diff/1/?file=1740249#file1740249line278>
> >
> >     If the readCount reaches numTreshold we could log a warning. 
> >     Or it can trigger a metrics counter.
> 
> hun shenshi wrote:
>     ok, I will log a warning.

I think log a warning is better


- hun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59743/#review176765
-----------------------------------------------------------


On 六月 2, 2017, 10:09 a.m., hun shenshi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59743/
> -----------------------------------------------------------
> 
> (Updated 六月 2, 2017, 10:09 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Bugs: FLUME-3101
>     https://issues.apache.org/jira/browse/FLUME-3101
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Add a threshold in TaildirSource. Use the threshold to control the number of 
> reads when a file is written by high frequency.
> 
> 
> Diffs
> -----
> 
>   
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java
>  a107a01 
> 
> 
> Diff: https://reviews.apache.org/r/59743/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean install -DskipTests -> built
> 
> 
> Thanks,
> 
> hun shenshi
> 
>

Reply via email to