> On 六月 7, 2017, 4:41 p.m., Denes Arvay wrote: > > Thank you for the patch. > > In general I think if this problem occurs then the load is higher what the > > actual Flume setup can handle, so the files won't be fully read unless the > > load decreases. On the other hand it might be good for some use cases to > > process other files instead of working on only one, so all in all I agree > > with the change. > > > > I had some comments, could you please fix those issues? > > Plus it'd be great if you could add this new configuration parameter to the > > User Guide as well. (`flume-ng-doc/sphinx/FlumeUserGuide.rst`, to check > > your changes you can generate the html files with the following commands: > > ``` > > $ export LC_ALL=C.UTF-8 # Required to build the javadocs on some platforms > > and in some locales > > $ mvn clean install -Psite -DskipTests > > ``` > > The output will be placed in the `target/site` directory. > > > > Let me know if you have any concerns regarding to my comments. > > hun shenshi wrote: > ok, I will fix those issues
Thank you for your comments. I have fix those issues. Please review. Thank you. - hun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59743/#review177175 ----------------------------------------------------------- On 六月 8, 2017, 2:16 p.m., hun shenshi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59743/ > ----------------------------------------------------------- > > (Updated 六月 8, 2017, 2:16 p.m.) > > > Review request for Flume. > > > Bugs: FLUME-3101 > https://issues.apache.org/jira/browse/FLUME-3101 > > > Repository: flume-git > > > Description > ------- > > Add a threshold in TaildirSource. Use the threshold to control the number of > reads when a file is written by high frequency. > > > Diffs > ----- > > flume-ng-doc/sphinx/FlumeUserGuide.rst a5d64f0 > > flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java > a107a01 > > flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java > f2347f3 > > flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java > 097ee0b > > > Diff: https://reviews.apache.org/r/59743/diff/5/ > > > Testing > ------- > > mvn clean install -DskipTests -> built > junit tests for flume-taildir-source module -> passed > > > Thanks, > > hun shenshi > >
