On Wed, Sep 13, 2017 at 5:40 PM Keith Turner <ke...@deenlo.com> wrote:
> On Wed, Sep 13, 2017 at 4:28 PM, Christopher <ctubb...@apache.org> wrote: > > The library-detectors findbugs plugin detects bugs at rank 11. Fluo is > > filtering out anything above 9, so to add in this plugin, it would > require > > triage-ing all bugs found up to at least rank 11. I don't know if that's > > worth holding up this update. > > I agree, its not worth holding this up. > > Upon taking a second look, even though Fluo is at maxRank 9, it seems to pass fine with maxRank 11, so in theory, it would be helpful to add it. However, in investigating the use of library-detectors findbugs plugin for Accumulo, Mike Miller and I have observed that the plugin isn't as useful as it first appears. Yes, it finds stuff, but there's no way to filter out exceptions, so I don't know that we'd want to enshrine it in the parent POM anyway, without that ability. > > > > On Wed, Sep 13, 2017 at 4:10 PM Christopher <ctubb...@apache.org> wrote: > > > >> Maybe. I can add it and see what impact it has. > >> > >> On Wed, Sep 13, 2017 at 9:28 AM Keith Turner <ke...@deenlo.com> wrote: > >> > >>> I checked all of the sigs and hashes and they look good. I am going > >>> to look over it some more, but before I do I was wondering about the > >>> Guava check stuff. Would make sense to abort this release and add the > >>> Guava beta check stuff recently added to Accumulo to parent pom? Then > >>> do another release with that? > >>> > >>> On Mon, Sep 11, 2017 at 5:44 PM, Christopher <ctubb...@apache.org> > wrote: > >>> > Fluo Developers, > >>> > > >>> > I've taken the liberty of preparing some release candidates to update > >>> our > >>> > build tooling. I've prepared both build-resources-2.0.0 and > >>> fluo-parent-2. > >>> > > >>> > Please consider the following candidate for Fluo Build Resources > 2.0.0. > >>> > > >>> > Git Commit: > >>> > 9784af748d2f3d12b243ef266b7e27805026ed81 > >>> > Branch: > >>> > build-resources-2.0.0-rc1 > >>> > > >>> > If this vote passes, a gpg-signed tag will be created using: > >>> > git tag -f -m 'Apache Fluo Build Resources 2.0.0' -s > >>> > rel/build-resources-2.0.0 \ > >>> > 9784af748d2f3d12b243ef266b7e27805026ed81 > >>> > > >>> > ALSO, please consider the following candidate for Fluo Parent POM 2. > >>> > > >>> > Git Commit: > >>> > 0491222187ac3f4bc76181ba2fb2e24aba04eff8 > >>> > Branch: > >>> > fluo-parent-2-rc1 > >>> > > >>> > If this vote passes, a gpg-signed tag will be created using: > >>> > git tag -f -m 'Apache Fluo Parent POM 2' -s rel/fluo-parent-2 \ > >>> > 0491222187ac3f4bc76181ba2fb2e24aba04eff8 > >>> > > >>> > > >>> > Staging repo: > >>> > > https://repository.apache.org/content/repositories/orgapachefluo-1019 > >>> > Source (official release artifact): > >>> > > >>> > https://repository.apache.org/content/repositories/orgapachefluo-1019/org/apache/fluo/build-resources/2.0.0/build-resources-2.0.0-source-release.tar.gz > >>> > Source (official release artifact): > >>> > > >>> > https://repository.apache.org/content/repositories/orgapachefluo-1019/org/apache/fluo/fluo-parent/2/fluo-parent-2-source-release.tar.gz > >>> > (Append ".sha1", ".md5", or ".asc" to download the signature/hash > for a > >>> > given artifact.) > >>> > > >>> > All artifacts were built and staged with: > >>> > mvn release:prepare && mvn release:perform > >>> > > >>> > Signing keys are available at https://www.apache.org/dist/fluo/KEYS > >>> > (Expected fingerprint: 8CC4F8A2B29C2B040F2B835D6F0CDAE700B6899D) > >>> > > >>> > Please vote one of: > >>> > [ ] +1 - I have verified and accept... > >>> > [ ] +0 - I have reservations, but not strong enough to vote > against... > >>> > [ ] -1 - Because..., I do not accept... > >>> > ... these artifacts as the 2.0.0 release of Apache Fluo Build > Resources. > >>> > > >>> > This vote will remain open until at least Thu Sep 14 22:00:00 UTC > 2017 > >>> (Thu > >>> > Sep 14 18:00:00 EDT 2017 / Thu Sep 14 15:00:00 PDT 2017). > >>> > Voting can continue after this deadline until the release manager > sends > >>> an > >>> > email ending the vote. > >>> > > >>> > Thanks! > >>> > > >>> > P.S. Hint: download the whole staging repo with > >>> > wget -erobots=off -r -l inf -np -nH \ > >>> > > >>> https://repository.apache.org/content/repositories/orgapachefluo-1019/ > >>> > # note the trailing slash is needed > >>> > >> >
