Hi Felix,
Thank you for the patch one more time. I will wait for the new version
as we have discussed on IRC meeting today.
Best regards,
Mikhail.
On 12/08/09 10:17, Zhang Xiaofei wrote:
Hi Mikhail,
Thank you for the advice, I have corrected them and did a little
polishing to the patch.
One small problem remains is that I can't find the way to convert a
String to OUString. Line 258 in this patch doesn't compile, and I failed
to find a documentation or an example for the conversion. Could you give
me a hint please?
By the way, I haven't come up with a proper name for the method Foo()
yet. I would love to hear your advice.
Thanks and Best Regards,
Felix.
Mikhail Voytenko
Hi Felix,
Thank you for the patch, it looks good in general from the first view.
There are some parts that still can be improved:
- the actual document filter should not be used to load the template;
the best way would be to get the template filter using TypeDetection
- in case the original template is copied back, the configuration
entry, that describes whether the template was changed, should be set
back
Best regards,
Mikhail.
On 12/04/09 10:35, Zhang Xiaofei wrote:
Hi Mikhail,
Here is another preliminary patch for i40233, please help me to
review it and tell me if anything needs to be modified.
Thank you, and Best Regards,
Felix.
------------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@framework.openoffice.org
For additional commands, e-mail: dev-h...@framework.openoffice.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@framework.openoffice.org
For additional commands, e-mail: dev-h...@framework.openoffice.org
------------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@framework.openoffice.org
For additional commands, e-mail: dev-h...@framework.openoffice.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@framework.openoffice.org
For additional commands, e-mail: dev-h...@framework.openoffice.org
