Hi Felix,
Thank you for the patch, it looks better.
There still seem to be some problems there. First of all, it looks like
the properties in "/org.openoffice.Setup/Office/Factories/" are read
without referencing the application specific node. That would mean that
all the properties just can not be retrieved/stored. I would recommend
also to check whether aAllExt is empty before using it.
On a state, when a patch contains all the functionality and already
might work, I would very appreciate if you would test it before sending.
The best way is to use debugger to debug it step by step, to be sure
that everything is executed as expected.
Thanks and Best regards,
Mikhail.
On 12/11/09 13:52, Zhang Xiaofei wrote:
Hi Mikhail,
Here's the improved patch thanks to your suggestions, please have a
look at it and check if anything still needs to be changed.
Thank you and Best Regards,
Felix.
Mikhail Voytenko
Hi Felix,
Thank you for the patch one more time. I will wait for the new
version as we have discussed on IRC meeting today.
Best regards,
Mikhail.
On 12/08/09 10:17, Zhang Xiaofei wrote:
Hi Mikhail,
Thank you for the advice, I have corrected them and did a little
polishing to the patch.
One small problem remains is that I can't find the way to convert a
String to OUString. Line 258 in this patch doesn't compile, and I
failed to find a documentation or an example for the conversion.
Could you give me a hint please?
By the way, I haven't come up with a proper name for the method
Foo() yet. I would love to hear your advice.
Thanks and Best Regards,
Felix.
Mikhail Voytenko
Hi Felix,
Thank you for the patch, it looks good in general from the first
view. There are some parts that still can be improved:
- the actual document filter should not be used to load the
template; the best way would be to get the template filter using
TypeDetection
- in case the original template is copied back, the configuration
entry, that describes whether the template was changed, should be
set back
Best regards,
Mikhail.
On 12/04/09 10:35, Zhang Xiaofei wrote:
Hi Mikhail,
Here is another preliminary patch for i40233, please help me to
review it and tell me if anything needs to be modified.
Thank you, and Best Regards,
Felix.
------------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
------------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
------------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
--
Sun Microsystems GmbH Mikhail Voytenko
Nagelsweg 55 Software Engineer
20097 Hamburg Phone: (+49 40)23646 500
Germany Fax: (+49 40)23646 550
http://www.sun.de mailto:[email protected]
Sitz der Gesellschaft:
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht München: HRB 161028
Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring
