[ https://issues.apache.org/jira/browse/GEODE-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900082#comment-15900082 ]
ASF GitHub Bot commented on GEODE-2578: --------------------------------------- Github user PivotalSarge commented on a diff in the pull request: https://github.com/apache/geode-native/pull/48#discussion_r104768886 --- Diff: src/cppcache/include/geode/DataOutput.hpp --- @@ -378,9 +378,8 @@ class CPPCACHE_EXPORT DataOutput { */ inline void writeFullUTF(const char* value, uint32_t length = 0) { if (value != NULL) { - int32_t len = getEncodedLength(value, length); - uint16_t encodedLen = static_cast<uint16_t>(len > 0xFFFF ? 0xFFFF : len); --- End diff -- If the query string happened to be longer that 0xFFFF, it would be artificially truncated which often led to errors on the server side. > Query string limited to 64 KiB > ------------------------------ > > Key: GEODE-2578 > URL: https://issues.apache.org/jira/browse/GEODE-2578 > Project: Geode > Issue Type: Bug > Components: native client > Reporter: Michael Dodge > Assignee: Michael Dodge > > The serialization of query strings uses a 16-bit unsigned integer to > represent the length of the query string. Query strings with more than 65535 > characters are silently truncated. Use of a 32-bit unsigned integer to > represent the length would greatly increase the size of query strings that > may be used. -- This message was sent by Atlassian JIRA (v6.3.15#6346)