[
https://issues.apache.org/jira/browse/GEODE-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900086#comment-15900086
]
ASF GitHub Bot commented on GEODE-2578:
---------------------------------------
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104769260
--- Diff: src/cppcache/test/TcrMessage_unittest.cpp ---
@@ -559,3 +560,66 @@ TEST_F(TcrMessageTest,
testConstructorEXECUTE_FUNCTION) {
"75746546756E6374696F6E0000000301570000",
testMessage);
}
+
+TEST_F(TcrMessageTest, testConstructorEXECUTECQ_MSG_TYPE) {
+ CacheablePtr myCacheablePtr(CacheableString::createDeserializable());
+
+ TcrMessageExecuteCq testMessage("ExecuteCQ", "select * from /somewhere",
+ CqState::RUNNING, false,
+ static_cast<ThinClientBaseDM *>(NULL));
+
+ EXPECT_EQ(TcrMessage::EXECUTECQ_MSG_TYPE, testMessage.getMessageType());
+
+ EXPECT_MESSAGE_EQ(
+
"0000002A0000004000000005FFFFFFFF0000000009004578656375746543510000001800"
+
"73656C656374202A2066726F6D202F736F6D657768657265000000040000000001000000"
+ "010000000000010001",
+ testMessage);
+}
+
+TEST_F(TcrMessageTest,
testConstructorWithGinormousQueryEXECUTECQ_MSG_TYPE) {
--- End diff --
I'm unaware of the SI definition of ginormous...
> Query string limited to 64 KiB
> ------------------------------
>
> Key: GEODE-2578
> URL: https://issues.apache.org/jira/browse/GEODE-2578
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Michael Dodge
> Assignee: Michael Dodge
>
> The serialization of query strings uses a 16-bit unsigned integer to
> represent the length of the query string. Query strings with more than 65535
> characters are silently truncated. Use of a 32-bit unsigned integer to
> represent the length would greatly increase the size of query strings that
> may be used.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
