[ https://issues.apache.org/jira/browse/GEODE-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900083#comment-15900083 ]
ASF GitHub Bot commented on GEODE-2578: --------------------------------------- Github user PivotalSarge commented on a diff in the pull request: https://github.com/apache/geode-native/pull/48#discussion_r104769132 --- Diff: src/cppcache/test/DataOutputTest.cpp --- @@ -305,15 +305,9 @@ TEST_F(DataOutputTest, TestCursorAdvance) { "001B596F7520686164206D65206174206D65617420746F726E61646F2E", dataOutput.getByteArray()); - EXPECT_EQ((2 + 27), dataOutput.getBufferLength()); - - // buffers are pre-allocated 8k and have 2 bytes to hold the data length - EXPECT_EQ(((8 * 1024) - (2 + 27)), dataOutput.getRemainingBufferLength()); --- End diff -- getRemainingBufferLength() is the call that exhibited less-than-obvious behavior. In particular, it appears to be affected by some global state. Its return value was not predictable enough to be tested in that manner. > Query string limited to 64 KiB > ------------------------------ > > Key: GEODE-2578 > URL: https://issues.apache.org/jira/browse/GEODE-2578 > Project: Geode > Issue Type: Bug > Components: native client > Reporter: Michael Dodge > Assignee: Michael Dodge > > The serialization of query strings uses a 16-bit unsigned integer to > represent the length of the query string. Query strings with more than 65535 > characters are silently truncated. Use of a 32-bit unsigned integer to > represent the length would greatly increase the size of query strings that > may be used. -- This message was sent by Atlassian JIRA (v6.3.15#6346)