----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43725/#review119649 -----------------------------------------------------------
This makes the test pass, but the test is now meaningless when run in an environment with DNS hijacking and could now allow a clean CI run when functionality has been broken. The launcher is supposed to reject a bind-address that doesn't work and it isn't doing that. In my opinion you should not check in this change and the ticket component should be changed to gfsh/management. The Builder class shouldn't accept a bind address that isn't an address of the machine on which it is launching, but it is doing so. - Bruce Schuchardt On Feb. 18, 2016, 5:50 p.m., Jianxia Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43725/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 5:50 p.m.) > > > Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo > Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Remove the expected exception since the DNS lookup result is > non-deterministic due to ISP DNS hijacking. Do not re-throw the exception in > the catch block. > > Do the same for LocatorLauncherJUnitTest as well. > > > Diffs > ----- > > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherJUnitTest.java > aa7e028 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java > 7240daa > > Diff: https://reviews.apache.org/r/43725/diff/ > > > Testing > ------- > > > Thanks, > > Jianxia Chen > >
