----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43725/#review119718 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java (line 1488) <https://reviews.apache.org/r/43725/#comment181060> Maybe we could have a better error message here - something like bindAddress + " is not an address for this machine" and not include an UnknownHostException since the name did actually resolve to an address. gemfire-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java (line 1966) <https://reviews.apache.org/r/43725/#comment181061> Same comment here gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherJUnitTest.java (line 145) <https://reviews.apache.org/r/43725/#comment181062> Change this and the other localHost test to throw the unexpected exception (throws Exception) instead of printing a stack trace. - Bruce Schuchardt On Feb. 18, 2016, 8:28 p.m., Jianxia Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43725/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 8:28 p.m.) > > > Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jens Deppe, > Jinmei Liao, Kirk Lund, and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Remove the expected exception since the DNS lookup result is > non-deterministic due to ISP DNS hijacking. Do not re-throw the exception in > the catch block. > > Do the same for LocatorLauncherJUnitTest as well. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java > d13dae5 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java > 4a2ce52 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherJUnitTest.java > aa7e028 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java > 7240daa > > Diff: https://reviews.apache.org/r/43725/diff/ > > > Testing > ------- > > > Thanks, > > Jianxia Chen > >
