----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43725/#review119651 -----------------------------------------------------------
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherJUnitTest.java (line 126) <https://reviews.apache.org/r/43725/#comment180994> Removing the expected exception fixes the ISP hijack problem but also potentially allows false positives. Would it make sense to mock the call to lookup the hostname? - Anthony Baker On Feb. 18, 2016, 5:50 p.m., Jianxia Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43725/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 5:50 p.m.) > > > Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo > Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Remove the expected exception since the DNS lookup result is > non-deterministic due to ISP DNS hijacking. Do not re-throw the exception in > the catch block. > > Do the same for LocatorLauncherJUnitTest as well. > > > Diffs > ----- > > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherJUnitTest.java > aa7e028 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java > 7240daa > > Diff: https://reviews.apache.org/r/43725/diff/ > > > Testing > ------- > > > Thanks, > > Jianxia Chen > >
