> On Aug. 22, 2016, 3:29 p.m., Bruce Schuchardt wrote: > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java, > > line 895 > > <https://reviews.apache.org/r/49962/diff/3/?file=1470397#file1470397line895> > > > > I don't think this can be transparent, but at the same time do we > > really need static methods on GMSMember for this when there are already > > instance methods? I also prefer the method names in > > InternalDistributedMember (write/readEssentialData) because "shallow" to me > > means not recursing into contained objects, such as "shallow copy".
agree.. - Hitesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49962/#review146361 ----------------------------------------------------------- On Aug. 10, 2016, 9:25 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49962/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2016, 9:25 p.m.) > > > Review request for geode, Bruce Schuchardt and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Removed extra fields from distributedmember while serialization/de. Planning > to do this in udp-security branch. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java > d5d0b8e > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/JoinLeave.java > 87409c5 > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 080bdb3 > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java > 5c0a327 > > geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberJUnitTest.java > 7eef594 > > Diff: https://reviews.apache.org/r/49962/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
