----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50242/ -----------------------------------------------------------
(Updated July 22, 2016, 6:26 p.m.) Review request for geode, Darrel Schneider and Swapnil Bawaskar. Changes ------- Updated the fix based on the review. Now the GatewaySenderEventProcessor will release the offheap if the event was not put onto region queue or it failed with an exception. Bugs: GEODE-1678 https://issues.apache.org/jira/browse/GEODE-1678 Repository: geode Description ------- During cache close or disconnect, a put into region queue of GatewaySenderEventImpl may fail. The reference hold by the GatewaySenderEventImpl will not be released later. Handle this case by release offheap as necessary. Diffs (updated) ----- geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionQueue.java 5108861 geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueue.java 85b50a1 geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderQueue.java ccdf42a geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderEventProcessor.java 11502af geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java d703c6e geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderEventProcessor.java ba839f4 geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderQueue.java 57d6e34 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/TestBlockingHARegionQueue.java d57290a Diff: https://reviews.apache.org/r/50242/diff/ Testing ------- precheckin. Thanks, Eric Shu