> On July 22, 2016, 8:33 p.m., Swapnil Bawaskar wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueue.java, > > line 619 > > <https://reviews.apache.org/r/50242/diff/2/?file=1451319#file1451319line619> > > > > As implemented this method always returns true. We should consider > > result of basicPut() on line 614 to determine the outcome of the operation.
basicPut in HARegionQueue relies on dace.putObject(), and dace.putObject() could return true even though it is not put onto the HARegionQueue for eliding events. We can not rely on its return value for future offheap implementation. Added the comment for the future work, if any. - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50242/#review143269 ----------------------------------------------------------- On July 28, 2016, 8:44 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50242/ > ----------------------------------------------------------- > > (Updated July 28, 2016, 8:44 p.m.) > > > Review request for geode, Darrel Schneider and Swapnil Bawaskar. > > > Bugs: GEODE-1678 > https://issues.apache.org/jira/browse/GEODE-1678 > > > Repository: geode > > > Description > ------- > > During cache close or disconnect, a put into region queue of > GatewaySenderEventImpl may fail. The reference hold by the > GatewaySenderEventImpl will not be released later. Handle this case by > release offheap as necessary. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionQueue.java > 5108861 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueue.java > 85b50a1 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderQueue.java > ccdf42a > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderEventProcessor.java > 11502af > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java > d21d6dc > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderEventProcessor.java > ba839f4 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderQueue.java > efa7870 > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/TestBlockingHARegionQueue.java > d57290a > > Diff: https://reviews.apache.org/r/50242/diff/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > >
