----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50242/#review143266 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionQueue.java (line 50) <https://reviews.apache.org/r/50242/#comment209049> Can you check all the callers of this and make sure they handle put returning false? I see one caller (com.gemstone.gemfire.internal.cache.wan.parallel.ParallelGatewaySenderEventProcessor.enqueueEvent(EnumListenerEvent, EntryEvent, Object)) that does this in the old code: this.queue.put(gatewayQueueEvent); gatewayQueueEvent = null; I think that code should be updated to use the boolean result of put and only null out gatewayQueueEvent if put returns true. geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/TestBlockingHARegionQueue.java (line 74) <https://reviews.apache.org/r/50242/#comment209046> Shouldn't this return the result of super.put(object)? - Darrel Schneider On July 22, 2016, 11:26 a.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50242/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 11:26 a.m.) > > > Review request for geode, Darrel Schneider and Swapnil Bawaskar. > > > Bugs: GEODE-1678 > https://issues.apache.org/jira/browse/GEODE-1678 > > > Repository: geode > > > Description > ------- > > During cache close or disconnect, a put into region queue of > GatewaySenderEventImpl may fail. The reference hold by the > GatewaySenderEventImpl will not be released later. Handle this case by > release offheap as necessary. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionQueue.java > 5108861 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueue.java > 85b50a1 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderQueue.java > ccdf42a > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderEventProcessor.java > 11502af > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java > d703c6e > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderEventProcessor.java > ba839f4 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderQueue.java > 57d6e34 > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/TestBlockingHARegionQueue.java > d57290a > > Diff: https://reviews.apache.org/r/50242/diff/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > >
