Source code with a consistent look-and-feel makes it easier for people to join the project community and contribute.
Let’s continue to keep reformatting commits separate from logic changes—otherwise it’s too hard to review. Anthony > On Oct 12, 2016, at 10:06 AM, Dan Smith <dsm...@pivotal.io> wrote: > > +1 > > This might be a good time to reformat the code since I don't think there > are too many long lived feature branches outstanding. > > -Dan > > On Wed, Oct 12, 2016 at 10:00 AM, Jared Stewart <jstew...@pivotal.io> wrote: > >> I would like to advocate for adding a Checkstyle <http://checkstyle. >> sourceforge.net/> or Spotless <https://github.com/diffplug/spotless> >> gradle task to our build process to ensure that all code checked in meets >> the formatting standards described on the wiki <https://cwiki.apache.org/ >> confluence/display/GEODE/Code+Style+Guide> (and in the intellij/eclipse >> formatter xml files in our repository). This will alleviate difficulties >> reviewing code when whitespace or formatting has changed since all code >> checked in will already comply with standards.
signature.asc
Description: Message signed with OpenPGP using GPGMail
