Jason Dillon wrote:
So far 2+ days, several patches... one PMC +1, one non-PMC +1 (with
caveat to ping JVZ)... now crazy problems with diff/patch.. which I'm
not exactly sure how that affects the current votes... or does adding
a new version of the patch negate anything else voted upon.
Have you narrowed down what the diff/patch problems were caused by so we
can avoid it in the future? It might be worthwhile to add a "Creating
and Applying Patches Best Practices" wiki page that discusses the
issues you encountered and how they can be avoided. The following mail
might be a good seed for the initial content of the page:
http://mail-archives.apache.org/mod_mbox/db-derby-dev/200603.mbox/[EMAIL
PROTECTED]
In regards to whether a vote needs to be restarted, I have started a new
thread "[PROPOSAL] Patch vote restart guidelines (was Re: [jira]
Updated: (GERONIMO-2161) [RTC] Remove Geronimo modules from
dependencyManagement in root pom.xml)".
All for work that took about an hour. I've spent much more time
trying to get folks to look at it and then hack up scripts to make the
build work most of the time. I don't know how much time other folks
have put in... but I'm guessing that collectively we have *wasted*
many hours on this one single minor change RTC.
It has highlighted some issues, so it hasn't been a complete waste of
time. I think it would be worthwhile gaining a better understanding of
the diff/patch issue as patches aren't only used during RTC.
Folks, development like this will not scale... it does not scale!
I'm trying to play along... but really if it is going to take this
much effort for relatively minor changes that are aimed at helping to
fix issues we have and move forward with projects that have been
lagging for months (the m2 migration in this case) then I'm not sure
how we will ever get anything done.
I don't think we will attract many new committers into this type of
environment. Its already resulted in several folks who had been
active before switching focus to other tasks/projects. I hope they
come back at some point, but I can see why they might want to apply
their time in more rewarding ways.
Hopefully those people will speak up for themselves.
John
--jason
On Jul 3, 2006, at 2:01 AM, Jason Dillon (JIRA) wrote:
[ http://issues.apache.org/jira/browse/GERONIMO-2161?page=all ]
Jason Dillon updated GERONIMO-2161:
-----------------------------------
Attachment: GERONIMO-2161-v3.patch
GERONIMO-2161-v3.patch is the same as v2 minus the changes to the
packaging plugin. This applied cleanly (spat out nothing with the -s
flag) on a fresh checkout of trunk with:
{noformat}
patch -p0 -s < GERONIMO-2161-v3.patch
{noformat}
The packaging changes are not directly related to the changes that
this issue is tracking, its additional clean up work... as well as
build debugging bits to add better logging.
I believe that the icky script foo above should produce the same
results (sans the logging output) as the v2 patch.
*NOTE:* I do not believe that it is needed to reapply v3 if you
already believe that v2 is acceptable.
[RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
-----------------------------------------------------------------------
Key: GERONIMO-2161
URL: http://issues.apache.org/jira/browse/GERONIMO-2161
Project: Geronimo
Type: Task
Security: public(Regular issues)
Components: buildsystem
Reporter: Jason Dillon
Assignee: Jason Dillon
Fix For: 1.2
Attachments: GERONIMO-2161-configs-v1.1.sub.patch,
GERONIMO-2161-v1.patch, GERONIMO-2161-v2.patch, GERONIMO-2161-v3.patch
As I have mentioned before, I believe we should remove the Geronimo
modules that are currently listed in the root pom.xml:
This reduces the configuration of the pom by *~500 lines*.
Modules that reference these as dependencies will need their pom's
adjusted to include <version>${pom.version}</version> and
<type>car</type> for the configs. But in many places version
already exists with the ${geronimoVersion} property... which kinda
negates the purpose of the dependencyManagement section anyways.
I believe that it is more work to keep track of every module in the
root pom than it is to specify the additonal elements (mostly just
<version>${pom.version}</version>) in child poms. There is no
additional maintenance, as the new elements never need to be changed.
Net effect if this change is less configuration to maintain and thus
a less brittle build that can adapt to change easier.
Specifically these should be removed:
{code:xml}
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>ge-activemq-rar</artifactId>
<version>${geronimoVersion}</version>
<type>rar</type>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-activation</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-client</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-client-builder</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-common</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-connector</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-connector-builder</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-converter</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-core</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-deploy-config</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-deploy-jsr88</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-deploy-tool</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-deployment</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-derby</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-directory</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-javamail-transport</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-j2ee</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-j2ee-builder</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-j2ee-schema</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-kernel</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-jetty</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-jetty-builder</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-jmx-remoting</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-mail</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-management</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-naming</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-naming-builder</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-security</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-security-builder</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-service-builder</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-system</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-test-ddbean</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-timer</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-tomcat</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-tomcat-builder</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-transaction</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-upgrade</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-util</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-web-builder</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-webservices</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-axis</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.modules</groupId>
<artifactId>geronimo-axis-builder</artifactId>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>activemq</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>activemq-broker</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>axis</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>axis-deployer</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>client</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>client-corba</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>client-deployer</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>client-security</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>client-system</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>console-jetty</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>console-tomcat</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>daytrader-jetty</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>daytrader-tomcat</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>directory</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>geronimo-gbean-deployer</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>hot-deployer</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>j2ee-corba</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>j2ee-deployer</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>j2ee-security</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>j2ee-server</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>j2ee-system</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>javamail</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>jetty</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>jetty-deployer</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>jsp-examples-jetty</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>jsp-examples-tomcat</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>ldap-demo-jetty</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>ldap-demo-tomcat</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>ldap-realm</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>online-deployer</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>openejb</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>openejb-deployer</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>project.properties</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>remote-deploy-jetty</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>remote-deploy-tomcat</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>rmi-naming</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>servlets-examples-jetty</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>servlets-examples-tomcat</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>sharedlib</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>shutdown</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>system-database</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>tomcat</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>tomcat-deployer</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>uddi-jetty</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>uddi-tomcat</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>unavailable-client-deployer</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>unavailable-ejb-deployer</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>unavailable-webservices-deployer</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>upgrade</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>upgrade-cli</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>welcome-jetty</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.configs</groupId>
<artifactId>welcome-tomcat</artifactId>
<type>car</type>
<version>${geronimoVersion}</version>
</dependency>
{code}
--This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
