IMO, as long as the change does not make cross-compatibility between tomcat and jetty containers any worse, and the same TCK cases still pass in both containers after any change, the change should be fine. Also, IMO, I think it is better to have this change in before the 3.0-beta release.
-RG On 09/23/2011 09:03 AM, han hongfang wrote: > Hi devs, > > Some update for this topic. > > I set org.apache.catalina.STRICT_SERVLET_COMPLIANCE=false (just as the default > value in tomcat), and then run the servlet package of TCK, only two cases > failed. > > http://tomcat.apache.org/tomcat-7.0-doc/config/systemprops.html#Specification > shows the value of org.apache.catalina.STRICT_SERVLET_COMPLIANCE has effect on > several other properties. Looking into tomcat source code, most of the > properties being effected take the value of > org.apache.catalina.STRICT_SERVLET_COMPLIANCE only if these properties are NOT > explicitly set. By setting the following properties as true, above-mentioned > failed TCK cases pass as well. > > org.apache.catalina.core.ApplicationContext.GET_RESOURCE_REQUIRE_SLASH=true > org.apache.catalina.core.ApplicationDispatcher.WRAP_SAME_OBJECT=true > org.apache.catalina.core.StandardHostValve.ACCESS_SESSION=true > org.apache.catalina.session.StandardSession.ACTIVITY_CHECK=true > org.apache.catalina.session.StandardSession.LAST_ACCESS_AT_START=true > > I also tried in jetty v8.0.1.v20110908 and geronimo-jetty trunk, travel sample > runs successfully. Both of them have no homepage access issue (i.e., 404 > error). > > Any objection to set org.apache.catalina.STRICT_SERVLET_COMPLIANCE=false in > geronimo tomcat? > > Best regards, > > Han Hong Fang (Janet) > hanhongfang AT apache.org <http://apache.org> > >
