I can't merge it right now - computer/availability issue - but it looks good enough to be integrated to me.
Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book Le mer. 30 mai 2018 à 22:38, Raymond Auge <raymond.a...@liferay.com> a écrit : > > Hello all, > > Would someone have some time to review this? I would really love to use these > spec bundles for the OSGi CDI Integration reference implementation at Apache > Aries. > > Sincerely, > - Ray > > On Wed, May 16, 2018 at 12:53 AM, Romain Manni-Bucau <rmannibu...@gmail.com> > wrote: >> >> >> >> Le mar. 15 mai 2018 23:06, Raymond Auge <raymond.a...@liferay.com> a écrit : >>> >>> FYI, I have to fixup the current PR because I goofed up, but I'm doing that >>> now. >>> >>> On Tue, May 15, 2018 at 5:00 PM, Romain Manni-Bucau <rmannibu...@gmail.com> >>> wrote: >>>> >>>> Hi Raymond >>>> >>>> Does it mean we can drop the providerlocator now? >>> >>> >>> Not with this change. >>> I believe you are referring to the Service Loader Mediator [1] (like Aries >>> SpiFly [2]), which I could do as a second PR if that is really wanted. >> >> >> If we dont need the osgi locator shade it would be a win yes. >> >> >>> >>>> >>>> >>>> +1 anyhow for the pr >> >> >> Side note: Im just back from holidays so will need some days to catch up. >> Dont hesitate to ping back if no reviews next week from anyone. >> >>> >>> Great! thx >>> >>> [1] https://osgi.org/specification/osgi.cmpn/7.0.0/service.loader.html >>> [2] http://aries.apache.org/modules/spi-fly.html >>> >>>> >>>> >>>> >>>> Le mar. 15 mai 2018 21:52, Raymond Auge <raymond.a...@liferay.com> a écrit >>>> : >>>>> >>>>> Hello All, >>>>> >>>>> As some of you know several of the OSGi RIs consume the specification >>>>> bundles produced by the Apache Geronimo project. >>>>> >>>>> In the last couple of OSGi releases we've been applying the requirement >>>>> for Portable Java Contracts as part of new and updated specs. Now as the >>>>> specs of OSGi Release 7 have finalized we're in need to close out the RIs. >>>>> >>>>> To that end I'd like to request the application of the Portable Java >>>>> Contracts to the Geronimo spec bundles. >>>>> >>>>> I've created an issue [1] and sent a PR [2] which makes the necessary >>>>> changes. >>>>> >>>>> Would someone be so kind as to review this? >>>>> >>>>> Next, if acceptable, would someone call a release? I'm not sure of the >>>>> specs can be released all at once, but that would be the best case >>>>> scenario. >>>>> >>>>> Sincerely, >>>>> - Ray >>>>> >>>>> [1] https://issues.apache.org/jira/browse/GERONIMO-6606 >>>>> [2] https://github.com/apache/geronimo-specs/pull/9 >>>>> >>>>> -- >>>>> Raymond Augé (@rotty3000) >>>>> Senior Software Architect Liferay, Inc. (@Liferay) >>>>> Board Member & EEG Co-Chair, OSGi Alliance (@OSGiAlliance) >>> >>> >>> >>> >>> -- >>> Raymond Augé (@rotty3000) >>> Senior Software Architect Liferay, Inc. (@Liferay) >>> Board Member & EEG Co-Chair, OSGi Alliance (@OSGiAlliance) > > > > > -- > Raymond Augé (@rotty3000) > Senior Software Architect Liferay, Inc. (@Liferay) > Board Member & EEG Co-Chair, OSGi Alliance (@OSGiAlliance)
