[ 
https://issues.apache.org/jira/browse/GIRAPH-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428139#comment-13428139
 ] 

Maja Kabiljo commented on GIRAPH-259:
-------------------------------------

After looking into code some more, I see what you are saying about 
MasterCompute and WorkerContext, and I agree. The thing that was confusing me 
there was that in my tests I was calling registerAggregator and useAggregator 
from vertex compute so didn't get why you kept mentioning WorkerContext :-) But 
definitely, if we are choosing between those two, MasterCompute is a better 
place.

I am making some changes right now, will upload the patch soon.
                
> TestBspBasic.testBspPageRank is broken
> --------------------------------------
>
>                 Key: GIRAPH-259
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-259
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-259-1.patch, GIRAPH-259-2.patch, 
> GIRAPH-259-3.patch
>
>
> Test crashes on line 152 in class SimplePageRankVertex in distributed mode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to