[ 
https://issues.apache.org/jira/browse/GIRAPH-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428538#comment-13428538
 ] 

Eli Reisman commented on GIRAPH-259:
------------------------------------

Hey something weird here, I have been cleaning up a patch where we move IO 
formats to their own directory and eliminate VertexWithConnectedComponentXXX 
and SimpleTextXXX IO formats because they do the same thing as 
IdWithValueTextOutputFormat, and suddenly I get this same 1-off test problem 
with aggregator writer test. expects 31, gets 32. Also I notice in the the log 
dumps when running jobs, the workers do display a super step count 1 less than 
the master. Does all this relate? Could the test fails be due to using IO 
formats in the test that get the aggregator # differently, or have a bug 
themselves? anyway please take a look if you can and tell me whether I should 
wait for this patch to solve it or try to do something, its GIRAPH-218.

Of the 3 duplicated out formats, IdWithValue did the most robust job (lets you 
pick field separators etc.) but if its bad, I should drop it in favor of one of 
the others, or fix it? Why do you think it would set this test off suddenly? 
this was on mvn verify too, not a "real pseudo" or cluster run. Kind of weird.

                
> TestBspBasic.testBspPageRank is broken
> --------------------------------------
>
>                 Key: GIRAPH-259
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-259
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-259-1.patch, GIRAPH-259-2.patch, 
> GIRAPH-259-3.patch, GIRAPH-259-4.patch
>
>
> Test crashes on line 152 in class SimplePageRankVertex in distributed mode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to