Eli, the sum error I get in the pseudo distributed mode. I tried your patch again, it passes mvn verify, and if I comment out the sum check (and leave the 31 check) it also passes tests in pseudo distributed mode. You can try running the tests again, I don't know why would it be any different.
On 8/6/12 6:49 PM, "Eli Reisman" <initialcont...@gmail.com> wrote: >I think this might have happened another time when I was changing these IO >formats over in an earlier version of this patch. It occurs because I am >eliminating 2 redundant text output formats as per Jakob's request, and >plugging IdWithValueXXX into the tests that used the old version before. I >will take another look at IdWithValue, it maybe it is doing something in >that test the old output format didn't that increments that aggregated >value? But yes, its the 31 expected, 32 received value in the test. >Everything else seems to work fine. If you run the patch against trunk >with >'mvn verify' you should get the same result I did? i can run it again too. >Thanks for the feedback, let me know if I can help get this to work >somehow, or if you realize there's something wrong with IdWithValue that >needs to change for it to replace those other 2 out formats. > > >On Sat, Aug 4, 2012 at 12:42 PM, Maja Kabiljo (JIRA) ><j...@apache.org>wrote: > >> >> [ >> >>https://issues.apache.org/jira/browse/GIRAPH-259?page=com.atlassian.jira. >>plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428666#c >>omment-13428666] >> >> Maja Kabiljo commented on GIRAPH-259: >> ------------------------------------- >> >> Eli, as for the change 31 -> 32 (TestBspBasic, lines 418-420), that test >> checks how many times each aggregator value was written to >> AggregatorWriter. Before this patch, in this test aggregators were not >> registered on master, they were registered only in WorkerContext, so in >> master superstep 0 master didn't have the aggregators so didn't write >>them >> then. Removing the need for aggregators to be registered on worker, I >> register aggregators in MasterCompute so now they are written to >> AggregatorWriter even in superstep 0. That's why I had to make this >>change. >> But are you sure you are getting that mistake, and not the "wrong value >>of >> SumAggreg: 30, should be: 15"? Because those checks come first in the >>test, >> and they don't work without this patch. I tried to run tests with your >> patch on GIRAPH-218 and I do get this sum error. >> >> Avery, I'll remove json then, since we are going to move aggregators >>away >> from zookeeper anyway. >> >> > TestBspBasic.testBspPageRank is broken >> > -------------------------------------- >> > >> > Key: GIRAPH-259 >> > URL: https://issues.apache.org/jira/browse/GIRAPH-259 >> > Project: Giraph >> > Issue Type: Bug >> > Reporter: Maja Kabiljo >> > Assignee: Maja Kabiljo >> > Attachments: GIRAPH-259-1.patch, GIRAPH-259-2.patch, >> GIRAPH-259-3.patch, GIRAPH-259-4.patch >> > >> > >> > Test crashes on line 152 in class SimplePageRankVertex in distributed >> mode. >> >> -- >> This message is automatically generated by JIRA. >> If you think it was sent incorrectly, please contact your JIRA >> administrators: >> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa >> For more information on JIRA, see: >>http://www.atlassian.com/software/jira >> >> >>
