[
https://issues.apache.org/jira/browse/GIRAPH-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545477#comment-13545477
]
Eli Reisman commented on GIRAPH-469:
------------------------------------
All of these refactors seem great. I love the idea of getting the
Giraph-specific business logic in GraphMapper into an abstract base and letting
mapper-specific code in GraphMapper just inherit this functionality. This will
make it easier to plug in a "pure YARN" implementation next to GraphMapper
later that does not inherit Mapper<Object,Object,Object,Object> and so on.
As for getting rid of the mapper-specific stuff in GraphMapper altogether, I
don't think we can do that while still retaining compatibility with MRv1 Hadoop
clusters.
> Cleanup GraphMapper
> -------------------
>
> Key: GIRAPH-469
> URL: https://issues.apache.org/jira/browse/GIRAPH-469
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
>
> I don't see why we even call a map() method seeing as we are overriding
> run(). We are clearly not particularly "mapreduce-y" so we should make it our
> entry point more clear than a map(). Also I think we should have something
> like a WorkerThread similar to MasterThread and clean up all of this to just
> creare whichever threads the node is assigned roles of.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
