[
https://issues.apache.org/jira/browse/GIRAPH-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545683#comment-13545683
]
Eli Reisman commented on GIRAPH-469:
------------------------------------
One thing I already will change about this patch is the name of the class that
is internally used in GraphMapper to house all the BSP/Giraph business logic
for the supersteps. I called it GraphWorker in the patch, and changed
corresponding getGraphMapper() calls to getGraphWorker() calls. This name gets
confusing with all of our prenamed *Worker* and *Master* classes. So instead of
GraphWorker, how about GraphTask ? GraphApplication ? or ... ?
> Cleanup GraphMapper
> -------------------
>
> Key: GIRAPH-469
> URL: https://issues.apache.org/jira/browse/GIRAPH-469
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Eli Reisman
> Attachments: GIRAPH-469-1-eli-idea.patch
>
>
> I don't see why we even call a map() method seeing as we are overriding
> run(). We are clearly not particularly "mapreduce-y" so we should make it our
> entry point more clear than a map(). Also I think we should have something
> like a WorkerThread similar to MasterThread and clean up all of this to just
> creare whichever threads the node is assigned roles of.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
