[ 
https://issues.apache.org/jira/browse/GIRAPH-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549293#comment-13549293
 ] 

Nitay Joffe commented on GIRAPH-469:
------------------------------------

Can you post link to your reviewboard (e.g. in summary so it's easy to find)
                
> Cleanup GraphMapper
> -------------------
>
>                 Key: GIRAPH-469
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-469
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>            Assignee: Eli Reisman
>         Attachments: GIRAPH-469-1-eli-idea.patch, GIRAPH-469-2.patch, 
> GIRAPH-469-3.patch
>
>
> I don't see why we even call a map() method seeing as we are overriding 
> run(). We are clearly not particularly "mapreduce-y" so we should make it our 
> entry point more clear than a map(). Also I think we should have something 
> like a WorkerThread similar to MasterThread and clean up all of this to just 
> creare whichever threads the node is assigned roles of. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to