umustafi commented on a change in pull request #3438:
URL: https://github.com/apache/gobblin/pull/3438#discussion_r762139706
##########
File path:
gobblin-modules/gobblin-sql/src/test/java/org/apache/gobblin/writer/JdbcPublisherTest.java
##########
@@ -87,6 +87,22 @@ public void testPublish() throws IOException, SQLException {
inOrder.verify(workUnitState,
times(1)).setWorkingState(WorkUnitState.WorkingState.COMMITTED);
inOrder.verify(conn, times(1)).commit();
inOrder.verify(conn, times(1)).close();
+ }
+
+ @Test(dependsOnMethods = { "testPublish" })
Review comment:
It's a bit hard to tell but these tests use `copyTable(database,
stagingTable, destinationTable)` which I modified above. However adding a unit
test in `MySqlBufferedInserterTest` would be a more direct approach to
achieving this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
