umustafi commented on a change in pull request #3438:
URL: https://github.com/apache/gobblin/pull/3438#discussion_r764417093
##########
File path:
gobblin-modules/gobblin-sql/src/main/java/org/apache/gobblin/writer/commands/BaseJdbcBufferedInserter.java
##########
@@ -65,6 +67,9 @@
protected PreparedStatement insertPstmtForFixedBatch;
private final Retryer<Boolean> retryer;
+ // If this config is true, the inserter can insert duplicate primary records
according to the specific language
+ protected final boolean replaceExistingValues;
Review comment:
fair argument, I moved this field to the base class of
`MySqlBufferedInserter` but not the other child classes because it is the only
one that implements this logic so far. As per your comment below I have added
it as a field to all the `*WriterCommands` that will fail fast if the config is
turned on before creating the `*Inserter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
