umustafi commented on a change in pull request #3438:
URL: https://github.com/apache/gobblin/pull/3438#discussion_r764300773
##########
File path:
gobblin-modules/gobblin-sql/src/test/java/org/apache/gobblin/writer/MySqlBufferedInserterTest.java
##########
@@ -63,7 +93,7 @@ public void testMySqlBufferedInsert() throws SQLException {
}
inserter.flush();
- verify(conn, times(2)).prepareStatement(anyString());
+ verify(conn, times(2)).prepareStatement(matches("REPLACE INTO .*"));
Review comment:
The MySQL writer commands does not have a similar test, which is why I
had modified the `JdbcPublisherTest` initially. There is a
`JdbcWriterCommandsTest` that mocks a `preparedStatement` to submit and
`execute` but it does not actually test insertions into the database. It only
tries to read from a mock database (see `testMySqlDateTypeRetrieval`) without
testing the other writer commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
