[
https://issues.apache.org/jira/browse/GOBBLIN-1675?focusedWorklogId=799052&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799052
]
ASF GitHub Bot logged work on GOBBLIN-1675:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/22 18:00
Start Date: 08/Aug/22 18:00
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3533:
URL: https://github.com/apache/gobblin/pull/3533#discussion_r940514917
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_store/MysqlSpecStore.java:
##########
@@ -138,7 +139,9 @@ protected SqlStatements createSqlStatements() {
/** Support search, unlike base class (presumably via a {@link
org.apache.gobblin.runtime.api.FlowSpecSearchObject}). */
@Override
public Collection<Spec> getSpecsImpl(SpecSearchObject specSearchObject)
throws IOException {
- return
withPreparedStatement(specSearchObject.augmentBaseGetStatement(this.sqlStatements.getStatementBase),
statement -> {
+ Boolean ifGetAll = ((FlowSpecSearchObject)specSearchObject).getGetAll();
Review Comment:
Is this necessary if we just trust that null (-1) start and count values
wouldn't add themselves to the statement, so we wouldn't have to do this check
since it would just be a sql statement without the OFFSET and LIMIT?
Issue Time Tracking
-------------------
Worklog Id: (was: 799052)
Time Spent: 0.5h (was: 20m)
> Paginate responses from get API on GaaS server side
> ---------------------------------------------------
>
> Key: GOBBLIN-1675
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1675
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Andy Jiang
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
