[ 
https://issues.apache.org/jira/browse/GOBBLIN-1675?focusedWorklogId=799827&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799827
 ]

ASF GitHub Bot logged work on GOBBLIN-1675:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Aug/22 20:52
            Start Date: 10/Aug/22 20:52
    Worklog Time Spent: 10m 
      Work Description: Will-Lo commented on code in PR #3533:
URL: https://github.com/apache/gobblin/pull/3533#discussion_r942896185


##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FlowSpecSearchObject.java:
##########
@@ -116,6 +119,13 @@ public String augmentBaseGetStatement(String baseStatement)
       conditions.add("owning_group = ?");
     }
 
+    if (this.getCount() > 0) {

Review Comment:
   Out of curiosity, do we/restli guard against count == 0 or negative values?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 799827)
    Time Spent: 1h 10m  (was: 1h)

> Paginate responses from get API on GaaS server side
> ---------------------------------------------------
>
>                 Key: GOBBLIN-1675
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1675
>             Project: Apache Gobblin
>          Issue Type: New Feature
>            Reporter: Andy Jiang
>            Priority: Major
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to