[
https://issues.apache.org/jira/browse/GOBBLIN-1675?focusedWorklogId=799070&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799070
]
ASF GitHub Bot logged work on GOBBLIN-1675:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/22 18:44
Start Date: 08/Aug/22 18:44
Worklog Time Spent: 10m
Work Description: AndyJiang99 commented on code in PR #3533:
URL: https://github.com/apache/gobblin/pull/3533#discussion_r940551812
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_store/MysqlSpecStore.java:
##########
@@ -138,7 +139,9 @@ protected SqlStatements createSqlStatements() {
/** Support search, unlike base class (presumably via a {@link
org.apache.gobblin.runtime.api.FlowSpecSearchObject}). */
@Override
public Collection<Spec> getSpecsImpl(SpecSearchObject specSearchObject)
throws IOException {
- return
withPreparedStatement(specSearchObject.augmentBaseGetStatement(this.sqlStatements.getStatementBase),
statement -> {
+ Boolean ifGetAll = ((FlowSpecSearchObject)specSearchObject).getGetAll();
Review Comment:
I think we may need to keep this logic because the ```GET_STATEMENT_BASE```
has an additional WHERE portion in the MySQL statement compared to the
```GET_ALL_STATEMENT```. If we just use
```this.sqlStatements.getStatementBase``` then the MySQL statement will be
incorrect because it has a hanging WHERE portion
Issue Time Tracking
-------------------
Worklog Id: (was: 799070)
Time Spent: 50m (was: 40m)
> Paginate responses from get API on GaaS server side
> ---------------------------------------------------
>
> Key: GOBBLIN-1675
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1675
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Andy Jiang
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
