[
https://issues.apache.org/jira/browse/GOBBLIN-1678?focusedWorklogId=800386&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-800386
]
ASF GitHub Bot logged work on GOBBLIN-1678:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Aug/22 21:45
Start Date: 12/Aug/22 21:45
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3536:
URL: https://github.com/apache/gobblin/pull/3536#issuecomment-1213542326
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3536?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3536](https://codecov.io/gh/apache/gobblin/pull/3536?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(57fd1d9) into
[master](https://codecov.io/gh/apache/gobblin/commit/9ce1e65aa36674742877b5aa2083412d85b5764f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(9ce1e65) will **increase** coverage by `0.04%`.
> The diff coverage is `77.95%`.
> :exclamation: Current head 57fd1d9 differs from pull request most recent
head 2e07398. Consider uploading reports for the commit 2e07398 to get more
accurate results
```diff
@@ Coverage Diff @@
## master #3536 +/- ##
============================================
+ Coverage 46.69% 46.73% +0.04%
- Complexity 10432 10472 +40
============================================
Files 2083 2087 +4
Lines 81516 81608 +92
Branches 9100 9097 -3
============================================
+ Hits 38061 38137 +76
- Misses 39944 39957 +13
- Partials 3511 3514 +3
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/gobblin/pull/3536/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh)
| `0.00% <ø> (ø)` | |
|
[.../org/apache/gobblin/service/ServiceConfigKeys.java](https://codecov.io/gh/apache/gobblin/pull/3536/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9TZXJ2aWNlQ29uZmlnS2V5cy5qYXZh)
| `0.00% <ø> (ø)` | |
|
[...ervice/modules/core/GobblinServiceGuiceModule.java](https://codecov.io/gh/apache/gobblin/pull/3536/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0dvYmJsaW5TZXJ2aWNlR3VpY2VNb2R1bGUuamF2YQ==)
| `89.62% <ø> (ø)` | |
|
[...in/service/modules/core/GobblinServiceManager.java](https://codecov.io/gh/apache/gobblin/pull/3536/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0dvYmJsaW5TZXJ2aWNlTWFuYWdlci5qYXZh)
| `50.00% <ø> (ø)` | |
|
[...obblin/util/filesystem/PathAlterationObserver.java](https://codecov.io/gh/apache/gobblin/pull/3536/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9QYXRoQWx0ZXJhdGlvbk9ic2VydmVyLmphdmE=)
| `0.00% <ø> (ø)` | |
|
[...bblin/service/monitoring/GitMonitoringService.java](https://codecov.io/gh/apache/gobblin/pull/3536/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9HaXRNb25pdG9yaW5nU2VydmljZS5qYXZh)
| `59.67% <54.54%> (ø)` | |
|
[...rvice/modules/flowgraph/BaseFlowGraphListener.java](https://codecov.io/gh/apache/gobblin/pull/3536/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvQmFzZUZsb3dHcmFwaExpc3RlbmVyLmphdmE=)
| `70.00% <62.96%> (ø)` | |
|
[...lin/service/modules/flow/MultiHopFlowCompiler.java](https://codecov.io/gh/apache/gobblin/pull/3536/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93L011bHRpSG9wRmxvd0NvbXBpbGVyLmphdmE=)
| `68.86% <66.66%> (-0.28%)` | :arrow_down: |
|
[.../gobblin/service/monitoring/GitConfigListener.java](https://codecov.io/gh/apache/gobblin/pull/3536/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9HaXRDb25maWdMaXN0ZW5lci5qYXZh)
| `78.57% <78.57%> (ø)` | |
|
[...obblin/service/monitoring/GitFlowGraphMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3536/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9HaXRGbG93R3JhcGhNb25pdG9yLmphdmE=)
| `83.87% <83.87%> (ø)` | |
| ... and [16
more](https://codecov.io/gh/apache/gobblin/pull/3536/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 800386)
Time Spent: 20m (was: 10m)
> Refactor GaaS Flowgraph Monitor to be extensible
> ------------------------------------------------
>
> Key: GOBBLIN-1678
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1678
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> To support new implementations of a flow graph monitor, which allows for live
> updating of a flowgraph, we should reuse as much implementation from the
> existing git flowgraph monitor as possible.
> The current flowgraph monitor has coupled logic to perform a lot of the
> adding node/edges which can be reused for a file based flowgraph.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
