[
https://issues.apache.org/jira/browse/GOBBLIN-1678?focusedWorklogId=801514&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-801514
]
ASF GitHub Bot logged work on GOBBLIN-1678:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Aug/22 22:29
Start Date: 17/Aug/22 22:29
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3536:
URL: https://github.com/apache/gobblin/pull/3536#discussion_r948492196
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java:
##########
@@ -32,6 +32,7 @@
import org.apache.commons.cli.ParseException;
import org.apache.commons.lang3.ObjectUtils;
import org.apache.gobblin.service.modules.orchestration.UserQuotaManager;
+import org.apache.gobblin.service.monitoring.GitConfigMonitor;
Review Comment:
The GitConfig monitor is actually referenced in this file, just that it used
to colocate itself in `org.apache.gobblin.service.modules.core;` but I moved it
to this other package after performing the refactoring to better reflect it's
purpose (and it shouldn't really live in the core package of GaaS considering
it isn't even in use!)
Issue Time Tracking
-------------------
Worklog Id: (was: 801514)
Time Spent: 1.5h (was: 1h 20m)
> Refactor GaaS Flowgraph Monitor to be extensible
> ------------------------------------------------
>
> Key: GOBBLIN-1678
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1678
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> To support new implementations of a flow graph monitor, which allows for live
> updating of a flowgraph, we should reuse as much implementation from the
> existing git flowgraph monitor as possible.
> The current flowgraph monitor has coupled logic to perform a lot of the
> adding node/edges which can be reused for a file based flowgraph.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
