[
https://issues.apache.org/jira/browse/GOBBLIN-1678?focusedWorklogId=801515&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-801515
]
ASF GitHub Bot logged work on GOBBLIN-1678:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Aug/22 22:34
Start Date: 17/Aug/22 22:34
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3536:
URL: https://github.com/apache/gobblin/pull/3536#discussion_r948496126
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/BaseFlowGraphListener.java:
##########
@@ -355,28 +290,6 @@ private List<SpecExecutor> getSpecExecutors(Config
edgeConfig)
return specExecutors;
}
- /**
Review Comment:
I think I accidentally moved the function up the file so it got a bit messed
up by Git, moving it back to clean up the diffs
Issue Time Tracking
-------------------
Worklog Id: (was: 801515)
Time Spent: 1h 40m (was: 1.5h)
> Refactor GaaS Flowgraph Monitor to be extensible
> ------------------------------------------------
>
> Key: GOBBLIN-1678
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1678
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> To support new implementations of a flow graph monitor, which allows for live
> updating of a flowgraph, we should reuse as much implementation from the
> existing git flowgraph monitor as possible.
> The current flowgraph monitor has coupled logic to perform a lot of the
> adding node/edges which can be reused for a file based flowgraph.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
