[
https://issues.apache.org/jira/browse/GOBBLIN-1673?focusedWorklogId=803067&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803067
]
ASF GitHub Bot logged work on GOBBLIN-1673:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/22 00:55
Start Date: 24/Aug/22 00:55
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3539:
URL: https://github.com/apache/gobblin/pull/3539#discussion_r953218336
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/messaging/DynamicWorkUnitUtils.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.runtime.messaging;
+
+import com.google.common.base.Optional;
+import com.google.gson.Gson;
+import com.google.gson.JsonElement;
+import com.google.gson.JsonObject;
+import java.time.Duration;
+import java.time.Instant;
+import java.time.temporal.ChronoUnit;
+import lombok.NonNull;
+import org.apache.gobblin.runtime.messaging.data.DynamicWorkUnitMessage;
+import org.apache.gobblin.util.LoggingUncaughtExceptionHandler;
+
+
+public final class DynamicWorkUnitUtils {
+ private static final Gson GSON = new Gson();
+ private static final String PROPS_PREFIX = "DynamicWorkUnit.Props";
+ private static final String MESSAGE_IMPLEMENTATION = PROPS_PREFIX +
".MessageImplementationClass";
+
+ private DynamicWorkUnitUtils() {
+ throw new RuntimeException("Cannot instantiate utils class");
+ }
+
+ /**
+ * Helper method for deserializing {@link DynamicWorkUnitMessage}
+ * @param json Serialized message using {@link DynamicWorkUnitUtils#toJson}
+ * @return {@link DynamicWorkUnitMessage} POJO representation of the given
json
+ */
+ public static <T extends DynamicWorkUnitMessage> DynamicWorkUnitMessage
fromJson(JsonElement json) {
+ try {
+ JsonObject obj = json.getAsJsonObject();
+ Class<T> clazz = (Class<T>)
Class.forName(obj.get(MESSAGE_IMPLEMENTATION).getAsString());
+ return GSON.fromJson(json, clazz);
+ } catch (IllegalStateException | ClassNotFoundException e) {
+ throw new RuntimeException(e);
Review Comment:
I'm not sure what the exception holds, so let's try to make it more
informative by saying what the input json is followed by the exception.
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/messaging/data/DynamicWorkUnitMessage.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.runtime.messaging.data;
+
+import com.google.gson.JsonElement;
+import gobblin.source.workunit.WorkUnit;
+
+
+public interface DynamicWorkUnitMessage {
Review Comment:
can you add a docstring here?
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/messaging/data/SplitWorkUnitMessage.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.runtime.messaging.data;
+
+import com.google.gson.JsonElement;
+import java.util.List;
+import lombok.Builder;
+import lombok.Value;
+import org.apache.gobblin.runtime.messaging.DynamicWorkUnitUtils;
+
+@Value
+@Builder
+public class SplitWorkUnitMessage implements DynamicWorkUnitMessage {
Review Comment:
doc for this class as well. what is the value of the
`laggingTopicPartitions`? They aren't used in this implementation of the class
so a description will help.
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/messaging/DynamicWorkUnitUtils.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.runtime.messaging;
+
+import com.google.common.base.Optional;
+import com.google.gson.Gson;
+import com.google.gson.JsonElement;
+import com.google.gson.JsonObject;
+import java.time.Duration;
+import java.time.Instant;
+import java.time.temporal.ChronoUnit;
+import lombok.NonNull;
+import org.apache.gobblin.runtime.messaging.data.DynamicWorkUnitMessage;
+import org.apache.gobblin.util.LoggingUncaughtExceptionHandler;
+
+
+public final class DynamicWorkUnitUtils {
+ private static final Gson GSON = new Gson();
+ private static final String PROPS_PREFIX = "DynamicWorkUnit.Props";
+ private static final String MESSAGE_IMPLEMENTATION = PROPS_PREFIX +
".MessageImplementationClass";
+
+ private DynamicWorkUnitUtils() {
+ throw new RuntimeException("Cannot instantiate utils class");
+ }
+
+ /**
+ * Helper method for deserializing {@link DynamicWorkUnitMessage}
+ * @param json Serialized message using {@link DynamicWorkUnitUtils#toJson}
+ * @return {@link DynamicWorkUnitMessage} POJO representation of the given
json
+ */
+ public static <T extends DynamicWorkUnitMessage> DynamicWorkUnitMessage
fromJson(JsonElement json) {
+ try {
+ JsonObject obj = json.getAsJsonObject();
+ Class<T> clazz = (Class<T>)
Class.forName(obj.get(MESSAGE_IMPLEMENTATION).getAsString());
+ return GSON.fromJson(json, clazz);
+ } catch (IllegalStateException | ClassNotFoundException e) {
+ throw new RuntimeException(e);
+ }
+ }
+
+ /**
+ * Helper method for serializing {@link DynamicWorkUnitMessage}
+ * @param msg Message object to serialize
+ * @return json representation of message object
+ */
+ public static JsonElement toJson(@NonNull DynamicWorkUnitMessage msg) {
+ JsonElement json = GSON.toJsonTree(msg);
+ JsonObject obj = json.getAsJsonObject();
+ obj.addProperty(MESSAGE_IMPLEMENTATION, msg.getClass().getName());
+ return obj;
+ }
+
+ /**
+ * Helper method for periodically executing runnable. Useful method to allow
{@link DynamicWorkUnitConsumer} to poll
+ * for new messages
+ * @param runnable
+ * @param timeBetweenRunStarts
+ */
+ public static void runInBackground(Runnable runnable, Duration
timeBetweenRunStarts) {
+ Thread idleProcessThread = new Thread(() -> {
+ while (true) {
+ Instant nextStartTime = Instant.now().plus(timeBetweenRunStarts);
+ runnable.run();
+ try {
+ long timeToSleepMs = Instant.now().until(nextStartTime,
ChronoUnit.MILLIS);
+ if(timeToSleepMs > 0) {
Review Comment:
do we want to wait a minimum time of `timeBetweenRunStarts` in case `run()`
method occurs quickly? It would be good to offer an explanation of why we don't
just sleep `timeBetweenRunStarts`
Issue Time Tracking
-------------------
Worklog Id: (was: 803067)
Remaining Estimate: 71.5h (was: 71h 40m)
Time Spent: 0.5h (was: 20m)
> [Helix Dynamic Workunit] Message Schema for splitting workuntis
> ---------------------------------------------------------------
>
> Key: GOBBLIN-1673
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1673
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-helix
> Reporter: Matthew Ho
> Assignee: Abhishek Tiwari
> Priority: Major
> Original Estimate: 72h
> Time Spent: 0.5h
> Remaining Estimate: 71.5h
>
> For the Helix Dynamic Workunits, task runners will produce messages
> indicating the current workunit health and the application master will
> consume these messages.
> A message will be sent from the task runner to the AM when the task runner
> experiences lag during ingestion. This ticket is the schema proposal for this
> message.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
