[
https://issues.apache.org/jira/browse/GOBBLIN-1673?focusedWorklogId=803331&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803331
]
ASF GitHub Bot logged work on GOBBLIN-1673:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/22 19:03
Start Date: 24/Aug/22 19:03
Worklog Time Spent: 10m
Work Description: hanghangliu commented on code in PR #3539:
URL: https://github.com/apache/gobblin/pull/3539#discussion_r954167978
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/messaging/data/DynamicWorkUnitMessage.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.runtime.messaging.data;
+
+import com.google.gson.JsonElement;
+import gobblin.source.workunit.WorkUnit;
+
+
+public interface DynamicWorkUnitMessage {
+ /**
+ * The workunit Id this message is associated with. Same as {@link
WorkUnit#getId()}
+ * @return workunit Id
+ */
+ String getWorkUnitId();
+
+ /**
+ * Serialize this class to Json
+ * @return serialized object
+ */
+ JsonElement toJson();
Review Comment:
Since you want to make DynamicWorkUnitMessage a POJO, maybe we shouldn't
restrict the way of serde. We can let the MessageBuffer to take care of
underlying communication mechanism and serde , and MessageBuffer can directly
return a collection of DynamicWorkUnitMessage POJO
Issue Time Tracking
-------------------
Worklog Id: (was: 803331)
Remaining Estimate: 71h 10m (was: 71h 20m)
Time Spent: 50m (was: 40m)
> [Helix Dynamic Workunit] Message Schema for splitting workuntis
> ---------------------------------------------------------------
>
> Key: GOBBLIN-1673
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1673
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-helix
> Reporter: Matthew Ho
> Assignee: Abhishek Tiwari
> Priority: Major
> Original Estimate: 72h
> Time Spent: 50m
> Remaining Estimate: 71h 10m
>
> For the Helix Dynamic Workunits, task runners will produce messages
> indicating the current workunit health and the application master will
> consume these messages.
> A message will be sent from the task runner to the AM when the task runner
> experiences lag during ingestion. This ticket is the schema proposal for this
> message.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
