[
https://issues.apache.org/jira/browse/GOBBLIN-1673?focusedWorklogId=804996&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-804996
]
ASF GitHub Bot logged work on GOBBLIN-1673:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/22 20:32
Start Date: 30/Aug/22 20:32
Worklog Time Spent: 10m
Work Description: rdsr commented on code in PR #3539:
URL: https://github.com/apache/gobblin/pull/3539#discussion_r958903341
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/messaging/DynamicWorkUnitConsumer.java:
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.runtime.messaging;
+
+import java.io.IOException;
+import java.util.Collection;
+import java.util.List;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import org.apache.gobblin.runtime.messaging.data.DynamicWorkUnitMessage;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+/**
+ * Abstraction for receiving {@link DynamicWorkUnitMessage} from {@link
DynamicWorkUnitProducer}.
+ * The class is responsible for fetching the messages from the messaging
service. All business logic
+ * should be done in the {@link DynamicWorkUnitMessage.Handler}.<br><br>
+ *
+ * This consumer can be used to poll a message buffer (e.g. HDFS or Kafka)
using
+ * {@link ScheduledExecutorService#scheduleAtFixedRate(Runnable, long, long,
TimeUnit)} to call the
+ * {@link Runnable#run()} method periodically in a background thread <br><br>
+ *
+ * Each new {@link DynamicWorkUnitMessage} is passed to a {@link
DynamicWorkUnitMessage.Handler}
+ * and will call {@link
DynamicWorkUnitMessage.Handler#handle(DynamicWorkUnitMessage)}
+ */
+public class DynamicWorkUnitConsumer implements Runnable {
+ private static final Logger LOG =
LoggerFactory.getLogger(DynamicWorkUnitConsumer.class);
+ protected MessageBuffer<DynamicWorkUnitMessage> buffer;
+ protected List<DynamicWorkUnitMessage.Handler> handlers;
Review Comment:
is there a convention to name fields ? like underscore or maybe just use
`this` keyword
Issue Time Tracking
-------------------
Worklog Id: (was: 804996)
Remaining Estimate: 70h 40m (was: 70h 50m)
Time Spent: 1h 20m (was: 1h 10m)
> [Helix Dynamic Workunit] Message Schema for splitting workuntis
> ---------------------------------------------------------------
>
> Key: GOBBLIN-1673
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1673
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-helix
> Reporter: Matthew Ho
> Assignee: Abhishek Tiwari
> Priority: Major
> Original Estimate: 72h
> Time Spent: 1h 20m
> Remaining Estimate: 70h 40m
>
> For the Helix Dynamic Workunits, task runners will produce messages
> indicating the current workunit health and the application master will
> consume these messages.
> A message will be sent from the task runner to the AM when the task runner
> experiences lag during ingestion. This ticket is the schema proposal for this
> message.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
