arjun4084346 commented on code in PR #3544:
URL: https://github.com/apache/gobblin/pull/3544#discussion_r959003407
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -191,6 +195,9 @@ public void onDeleteSpec(URI deletedSpecURI, String
deletedSpecVersion, Properti
@Override
public void onUpdateSpec(Spec updatedSpec) {
_log.info("Spec changed: " + updatedSpec);
+ if (updatedSpec instanceof FlowSpec) {
Review Comment:
Don't we want to call `onDeleteSpec` and `onAddSpec` for FlowSpec, like we
are doing for TopologySpec?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -191,6 +195,9 @@ public void onDeleteSpec(URI deletedSpecURI, String
deletedSpecVersion, Properti
@Override
public void onUpdateSpec(Spec updatedSpec) {
_log.info("Spec changed: " + updatedSpec);
+ if (updatedSpec instanceof FlowSpec) {
Review Comment:
Don't we want to call `onDeleteSpec` and `onAddSpec` sequentially for
FlowSpec, like we are doing for TopologySpec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
